fix: start param for wf not work #15544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongjiajie
requested review from
caishunfeng,
SbloodyS and
ruanwenjun
as code owners
zhongjiajie
commented
Feb 1, 2024
| @@ -199,7 +224,7 @@ public Map<String, Property> paramParsingPreparation(@NonNull TaskInstance taskI | |||
| } | |||
|
|
|||
| if (MapUtils.isNotEmpty(cmdParam)) { | |||
| prepareParamsMap.putAll(ParameterUtils.getUserDefParamsMap(cmdParam)); | |||
| prepareParamsMap.putAll(parseWorkflowStartParam(cmdParam)); | |||
There was a problem hiding this comment.
the key reason for this bug.
and others just for some refactor
|
Hi, @zhongjiajie please fix the CI |
zhongjiajie
force-pushed
the
start-param-pass
branch
from
30b427e
to
d52aa5a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15544 +/- ##
============================================
- Coverage 38.40% 38.39% -0.02%
+ Complexity 4752 4747 -5
============================================
Files 1305 1305
Lines 44847 44831 -16
Branches 4810 4801 -9
============================================
- Hits 17225 17213 -12
+ Misses 25748 25744 -4
Partials 1874 1874 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #15280
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md