[Fix][Shell] Fix the issue where execution is not successful in source limit mode #15568
Conversation
JohnZp
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
| if (PropertyUtils.getBoolean(AbstractCommandExecutorConstants.TASK_RESOURCE_LIMIT_STATE, false) | ||
| && (memoryQuota != -1 || cpuQuota != -1)) { |
There was a problem hiding this comment.
| if (PropertyUtils.getBoolean(AbstractCommandExecutorConstants.TASK_RESOURCE_LIMIT_STATE, false) | |
| && (memoryQuota != -1 || cpuQuota != -1)) { | |
| if (PropertyUtils.getBoolean(AbstractCommandExecutorConstants.TASK_RESOURCE_LIMIT_STATE, false)) { |
I do not suggest adding the quota judge here.
| // Some systems do not support infinity. Consider replacing it with a very large value. | ||
| bootstrapCommand.add(String.format("MemoryLimit=%s", "104857600M")); |
There was a problem hiding this comment.
It's better to add a new adaptor implementation for the specific system.
ruanwenjun
changed the title
ruanwenjun
changed the title
…source limit mode
ruanwenjun
force-pushed
the
fix_command_build
branch
from
0486523
to
6248cda
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15568 +/- ##
============================================
- Coverage 38.55% 38.52% -0.03%
+ Complexity 4776 4771 -5
============================================
Files 1310 1310
Lines 44880 44882 +2
Branches 4808 4809 +1
============================================
- Hits 17304 17293 -11
- Misses 25693 25706 +13
Partials 1883 1883 ☔ View full report in Codecov by Sentry. |
|
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
Purpose of the pull request
Brief change log
Considering using 104857600M as a replacement for infinity, not sure if it's appropriate.