Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix WorkflowInstance batch start failed will throw incorrect exception. #15577

Merged
merged 1 commit into from
Feb 6, 2024
Merged

[Fix] Fix WorkflowInstance batch start failed will throw incorrect exception. #15577

merged 1 commit into from
Feb 6, 2024

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented Feb 6, 2024

fix typo

@ruanwenjun ruanwenjun changed the title [Fix] fix typo [Fix] Fix WorkflowInstance batch start failed will throw incorrect exception. Feb 6, 2024
@ruanwenjun ruanwenjun added 3.2.1 minor Chore Chores about the project, like code clean, typo, etc. labels Feb 6, 2024
ruanwenjun
ruanwenjun approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS added this to the 3.2.1 milestone Feb 6, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Feb 6, 2024
fuchanghai
fuchanghai approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rickchengx
rickchengx approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@qingwli qingwli merged commit 73a5a77 into apache:dev Feb 6, 2024
56 checks passed
@qingwli qingwli deleted the fix-typo branch February 6, 2024 05:16
zhongjiajie pushed a commit that referenced this pull request Feb 6, 2024
@qingwli @zhongjiajie
[Fix] Fix WorkflowInstance batch start failed will throw incorrect ex…
0b72299 
…ception. (#15577)

(cherry picked from commit 73a5a77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickchengx rickchengx rickchengx approved these changes

@fuchanghai fuchanghai fuchanghai approved these changes

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@qingwli qingwli

Labels
3.2.1 backend improvement make more easy to user or prompt friendly minor Chore Chores about the project, like code clean, typo, etc. ready-to-merge
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
5 participants
@qingwli @ruanwenjun @fuchanghai @rickchengx @SbloodyS