[Fix][e2e] Fix e2e failed due to server overload. #15578
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15578 +/- ##
=========================================
Coverage 39.11% 39.11%
Complexity 4887 4887
=========================================
Files 1326 1326
Lines 45206 45206
Branches 4818 4818
=========================================
Hits 17683 17683
Misses 25635 25635
Partials 1888 1888 ☔ View full report in Codecov by Sentry. |
jackyyyyyssss
changed the title
SbloodyS
added
improvement
| @@ -191,7 +191,7 @@ master: | |||
| server-load-protection: | |||
| enabled: true | |||
| # Master max cpu usage, when the master's cpu usage is smaller then this value, master server can execute workflow. | |||
| max-cpu-usage-percentage-thresholds: 0.9 | |||
| max-cpu-usage-percentage-thresholds: 1.5 | |||
There was a problem hiding this comment.
| max-cpu-usage-percentage-thresholds: 1.5 | |
| max-cpu-usage-percentage-thresholds: 1.0 |
The max value of this parameter shouldld be 1.0.
| @@ -216,7 +216,7 @@ worker: | |||
| server-load-protection: | |||
| enabled: true | |||
| # Worker max cpu usage, when the worker's cpu usage is smaller then this value, worker server can be dispatched tasks. | |||
| max-cpu-usage-percentage-thresholds: 0.9 | |||
| max-cpu-usage-percentage-thresholds: 1.5 | |||
There was a problem hiding this comment.
| max-cpu-usage-percentage-thresholds: 1.5 | |
| max-cpu-usage-percentage-thresholds: 1.0 |
There was a problem hiding this comment.
@ruanwenjun Hello Sometimes the utilization rate of underlying resources can be greater than 1, so setting it to 1.5 can overload and cause e2e failure if set to 1
There was a problem hiding this comment.
This should be a bug, we may need to use getTotalCpuUsedPercentage() to compare with maxCpuUsagePercentageThresholds at ServerLoadProtection
ruanwenjun
changed the title
|
Due to 3.2.1 has been released, and this will not affect the release package, I removed the 3.2.1 milestone. |
|
|
|
Since this PR is no longer updated, I submit #15803 to fix this problem, thanks for your PR. |
Purpose of the pull request
fix #15579
fix e2e sometimes error Reduce the probability of e2e errors. Currently, it has been found that some cases of e2e errors are as follows: 1. Because the automated testing browser cannot click on the switch, switch to a different writing method for clicking. 2. the resource is overloaded, increase the load parameter, first modify a few core methods to reduce the failure rate, and then modify based on the failed cases
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md