Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-14863][API] Support to manage what worker groups can be used for a project. #15600

Merged
merged 32 commits into from
Feb 20, 2024

Conversation

calvinjiang
Copy link
Contributor

Purpose of the pull request

This PR will close #14863.

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.

The testing results are as follows:

image

image

image

@github-actions github-actions bot added UI ui and front end related backend labels Feb 20, 2024
@calvinjiang calvinjiang added this to the 3.2.2 milestone Feb 20, 2024
@calvinjiang calvinjiang added the improvement make more easy to user or prompt friendly label Feb 20, 2024
@calvinjiang calvinjiang changed the title [Improvement-14863][API] Support to manage what worker groups can be used for a project. [Feature-14863][API] Support to manage what worker groups can be used for a project. Feb 20, 2024
@calvinjiang calvinjiang added feature new feature ready-to-merge and removed improvement make more easy to user or prompt friendly labels Feb 20, 2024
projectWorkerGroup.setUpdateTime(now);
int create = projectWorkerGroupMapper.insert(projectWorkerGroup);
if (create > 0) {
log.info("Success to add worker group [{}] for the project [{}] .", workerGroupName,

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.
log.info("Success to add worker group [{}] for the project [{}] .", workerGroupName,
project.getName());
} else {
log.error("Failed to add worker group [{}] for the project [{}].", workerGroupName,

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (8a35e8b) 38.55% compared to head (b718908) 38.58%.

❗ Current head b718908 differs from pull request most recent head f918784. Consider uploading reports for the commit f918784 to get more accurate results

Files Patch % Lines
...ce/impl/ProjectWorkerGroupRelationServiceImpl.java 61.79% 26 Missing and 8 partials ⚠️
...r/api/controller/ProjectWorkerGroupController.java 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15600      +/-   ##
============================================
+ Coverage     38.55%   38.58%   +0.02%     
- Complexity     4777     4784       +7     
============================================
  Files          1310     1312       +2     
  Lines         44880    44978      +98     
  Branches       4808     4819      +11     
============================================
+ Hits          17305    17354      +49     
- Misses        25692    25734      +42     
- Partials       1883     1890       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 20, 2024

Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhuangchong zhuangchong merged commit 5213290 into apache:dev Feb 20, 2024
62 of 65 checks passed
@SbloodyS SbloodyS modified the milestones: 3.2.2, 3.3.0 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend feature new feature ready-to-merge UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][API] Support to manage what worker groups can be used for a project.
4 participants