Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] [dolphinscheduler-ui] UI timed scheduler Improvement #15624

Merged
merged 10 commits into from
Mar 6, 2024

Conversation

cqutwangyu
Copy link
Contributor

Purpose of the pull request

fix #15623

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added the UI ui and front end related label Feb 23, 2024
@cqutwangyu
Copy link
Contributor Author

@songjianet @Amy0104
please cc

@Gallardot
Copy link
Member

@cqutwangyu
Thanks for your contribution, can you upload a page snapshot at the same time?

@cqutwangyu
Copy link
Contributor Author

@Gallardot
ok,I recorded the video

this is error

20240223_221102.mp4

this is fix

20240223_221019.mp4

songjianet
songjianet previously approved these changes Feb 26, 2024
@songjianet
Copy link
Member

image

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.61%. Comparing base (04a6b0d) to head (7615e4e).

❗ Current head 7615e4e differs from pull request most recent head 6bc8ff2. Consider uploading reports for the commit 6bc8ff2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15624      +/-   ##
============================================
- Coverage     38.63%   38.61%   -0.03%     
+ Complexity     4795     4791       -4     
============================================
  Files          1316     1316              
  Lines         44969    44969              
  Branches       4817     4817              
============================================
- Hits          17373    17363      -10     
- Misses        25713    25724      +11     
+ Partials       1883     1882       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cqutwangyu
Copy link
Contributor Author

cqutwangyu commented Feb 26, 2024 via email

@rickchengx
Copy link
Contributor

cc @c3Vu @arlendp

@Gallardot
Copy link
Member

Gallardot commented Feb 27, 2024

I have tested this PR in my dev cluster, it works well and the issue has been fixed. Thanks @cqutwangyu .

What should be the next step to proceed with this PR?

@songjianet @cqutwangyu @rickchengx

@rickchengx
Copy link
Contributor

I have tested this PR in my dev cluster, it works well and the issue has been fixed. Thanks @cqutwangyu .

What should be the next step to proceed with this PR?

@songjianet @cqutwangyu @rickchengx

@cqutwangyu please fix the failed CI

@cqutwangyu cqutwangyu changed the title [Bug] [dolphinscheduler-ui] UI timed scheduler Improvement [bug] [dolphinscheduler-ui] UI timed scheduler Improvement Mar 1, 2024
@cqutwangyu
Copy link
Contributor Author

I have tested this PR in my dev cluster, it works well and the issue has been fixed. Thanks @cqutwangyu .
What should be the next step to proceed with this PR?
@songjianet @cqutwangyu @rickchengx

@cqutwangyu please fix the failed CI

OK, FIXED

@arlendp
Copy link
Contributor

arlendp commented Mar 4, 2024

cc @c3Vu @arlendp

i test the pr in local dev environment, it works as expected and did solve #15623 @rickchengx

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx rickchengx added 3.2.2 bug Something isn't working labels Mar 5, 2024
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rickchengx rickchengx merged commit e984300 into apache:dev Mar 6, 2024
58 checks passed
Gallardot pushed a commit to Gallardot/dolphinscheduler that referenced this pull request Mar 14, 2024
)

* Update use-table.ts

* [Fix][CI] Remove useless code

* [Fix][CI] Remove useless code

* [Fix][CI] Remove useless code

---------

Co-authored-by: Rick Cheng <[email protected]>
Co-authored-by: 旺阳 <[email protected]>
Co-authored-by: xiangzihao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 bug Something isn't working ready-to-merge UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [dolphinscheduler-ui] UI timed scheduler Improvement
8 participants