-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] [dolphinscheduler-ui] UI timed scheduler Improvement #15624
Conversation
@songjianet @Amy0104 |
@cqutwangyu |
@Gallardot this is error 20240223_221102.mp4this is fix 20240223_221019.mp4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15624 +/- ##
============================================
- Coverage 38.63% 38.61% -0.03%
+ Complexity 4795 4791 -4
============================================
Files 1316 1316
Lines 44969 44969
Branches 4817 4817
============================================
- Hits 17373 17363 -10
- Misses 25713 25724 +11
+ Partials 1883 1882 -1 ☔ View full report in Codecov by Sentry. |
Hello, I checked the error message and I found that the error message is not related to the content I modified. I then executed the pnpm run build:prod command on my computer, and the package was successful.
…---Original---
From: ***@***.***>
Date: Mon, Feb 26, 2024 08:38 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [apache/dolphinscheduler] [Bug] [dolphinscheduler-ui] UI timed scheduler Improvement (PR #15624)
image.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I have tested this PR in my dev cluster, it works well and the issue has been fixed. Thanks @cqutwangyu . What should be the next step to proceed with this PR? |
@cqutwangyu please fix the failed CI |
OK, FIXED |
i test the pr in local dev environment, it works as expected and did solve #15623 @rickchengx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
) * Update use-table.ts * [Fix][CI] Remove useless code * [Fix][CI] Remove useless code * [Fix][CI] Remove useless code --------- Co-authored-by: Rick Cheng <[email protected]> Co-authored-by: 旺阳 <[email protected]> Co-authored-by: xiangzihao <[email protected]>
Purpose of the pull request
fix #15623
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md