-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: modify some CODEOWNERS #15654
Conversation
.github/CODEOWNERS
Outdated
@@ -23,7 +23,7 @@ | |||
/dolphinscheduler-registry/ @caishunfeng @ruanwenjun | |||
/dolphinscheduler-api/ @caishunfeng @SbloodyS | |||
/dolphinscheduler-dao/ @caishunfeng @SbloodyS | |||
/dolphinscheduler-dao/src/main/resources/sql/ @zhongjiajie | |||
/dolphinscheduler-dao/src/main/resources/sql/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did some of our team interested be new code owner for /dolphinscheduler-dao/src/main/resources/sql/
module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about @EricGao888 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add one more commit and assign those to you 💯
.github/CODEOWNERS
Outdated
/licenses/ @zhongjiajie | ||
/images/ @zhongjiajie @EricGao888 | ||
/docs/ @EricGao888 | ||
/licenses/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did some of our team interested be new code owner for /licenses/
directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
93cd09d
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15654 +/- ##
============================================
+ Coverage 38.57% 38.58% +0.01%
- Complexity 4792 4794 +2
============================================
Files 1316 1316
Lines 45043 45043
Branches 4823 4823
============================================
+ Hits 17374 17382 +8
+ Misses 25779 25769 -10
- Partials 1890 1892 +2 ☔ View full report in Codecov by Sentry. |
93cd09d
to
1c130c0
Compare
Please retry analysis of this Pull-Request directly on SonarCloud |
I'll be away from the community for a while, and I've removed me from the codeowner configurations to reduce notification for my mailbox