Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-15639] [Master] parameterPassing is null case NPE #15678

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

liuchunhua
Copy link
Contributor

Purpose of the pull request

resolve #15639

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng
Copy link
Contributor

@caishunfeng caishunfeng added the bug Something isn't working label Mar 7, 2024
@caishunfeng caishunfeng added this to the 3.2.2 milestone Mar 7, 2024
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@caishunfeng caishunfeng merged commit e3fdb1a into apache:dev Mar 8, 2024
56 checks passed
@liuchunhua liuchunhua deleted the fix_dependent_npe branch March 9, 2024 01:51
ZhongJinHacker pushed a commit to ZhongJinHacker/dolphinscheduler that referenced this pull request Mar 11, 2024
SbloodyS pushed a commit that referenced this pull request Mar 11, 2024
…15689)

* clean unused import

* fix style check

* fix when path is null or empty, it will cause serverhost is null,

* fix UT test (#15684)

* [Fix-15639] parameterPassing is null case NPE (#15678)

Co-authored-by: caishunfeng <[email protected]>

* fix  when path is null or empty, it will cause serverhost is null,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [MASTER] DependentExecute.java:398 NPE
3 participants