Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix Complement data Tenant abnormality #16092

Merged
merged 1 commit into from
May 31, 2024

Conversation

changxiangshimian
Copy link
Contributor

@changxiangshimian changxiangshimian commented May 30, 2024

fix #15366
fix #16010

Purpose of the pull request

Fix Complement data Tenant abnormality

Brief change log

Add setTenantCode for Command to WorkflowExecuteRunnable.java file

Verify this pull request

This pull request is already covered by existing tests, such as org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteRunnableTest.

@SbloodyS SbloodyS changed the title Fix Complement data Tenant abnormality [Bug] Fix Complement data Tenant abnormality May 30, 2024
@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor 3.3.0 labels May 30, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone May 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.68%. Comparing base (d8e0178) to head (6ccd0f7).

Current head 6ccd0f7 differs from pull request most recent head d6f20b4

Please upload reports for the commit d6f20b4 to get more accurate results.

Files Patch % Lines
.../server/master/runner/WorkflowExecuteRunnable.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #16092   +/-   ##
=========================================
  Coverage     40.67%   40.68%           
- Complexity     5238     5239    +1     
=========================================
  Files          1382     1382           
  Lines         46023    46024    +1     
  Branches       4922     4922           
=========================================
+ Hits          18719    18724    +5     
+ Misses        25379    25375    -4     
  Partials       1925     1925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented May 30, 2024

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit d675c28 into apache:dev May 31, 2024
55 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment