Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task cannot use workflow's environment (#16199) #16206

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ruanwenjun
Copy link
Member

(cherry picked from commit b34fe46)

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added backend e2e e2e test labels Jun 24, 2024
@SbloodyS SbloodyS added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Jun 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 45.45455% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (3.2.2-prepare@2f928b1). Learn more about missing BASE report.

Current head b9d1a86 differs from pull request most recent head 21477a2

Please upload reports for the commit 21477a2 to get more accurate results.

Files Patch % Lines
.../server/master/runner/WorkflowExecuteRunnable.java 0.00% 8 Missing ⚠️
...erver/master/runner/StreamTaskExecuteRunnable.java 0.00% 4 Missing ⚠️
...uler/server/master/registry/ServerNodeManager.java 0.00% 3 Missing ⚠️
...e/dolphinscheduler/dao/utils/EnvironmentUtils.java 80.00% 1 Missing ⚠️
...e/dolphinscheduler/dao/utils/WorkerGroupUtils.java 80.00% 1 Missing ⚠️
...cheduler/scheduler/quartz/ProcessScheduleTask.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             3.2.2-prepare   #16206   +/-   ##
================================================
  Coverage                 ?   40.52%           
  Complexity               ?     5221           
================================================
  Files                    ?     1381           
  Lines                    ?    46062           
  Branches                 ?     4904           
================================================
  Hits                     ?    18666           
  Misses                   ?    25469           
  Partials                 ?     1927           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
40.3% Coverage on New Code (required ≥ 60%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ruanwenjun ruanwenjun merged commit e65208b into apache:3.2.2-prepare Jun 24, 2024
59 of 62 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_cp16172 branch June 24, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend e2e e2e test release cherry-pick Mark this issue/PR had cherry-pick for release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants