Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-16527][alert] Add retry send email validAddresses when abnormal addresses in the email receiving list #16529

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

nelsontech
Copy link

@nelsontech nelsontech commented Aug 27, 2024

Purpose of the pull request

The content of this commit adjusts the email notification module so that when invalid email addresses are included among multiple recipients, it does not prevent all recipients from receiving emails. Instead, emails will continue to be delivered to the actual valid email addresses.

close #16527

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

email alert to user whose email address is valid, and add other email address which is invalid ,when send email alert, the part of valid email address will receive the email alert message

@nelsontech nelsontech requested a review from SbloodyS as a code owner August 27, 2024 09:21
@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor labels Aug 27, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Aug 27, 2024
@github-actions github-actions bot added the test label Aug 28, 2024
Comment on lines +166 to +174
@Test
public void testReceiversWithInvalidAddress() {
String content = list2String();
emailConfig.put(AlertConstants.NAME_SHOW_TYPE, ShowType.TABLE_ATTACHMENT.getDescp());
emailConfig.put(MailParamsConstants.NAME_PLUGIN_DEFAULT_EMAIL_RECEIVERS, "[email protected],[email protected]");
mailSender = new MailSender(emailConfig);
AlertResult alertResult = mailSender.sendMails("gaojing", content);
Assertions.assertFalse(alertResult.isSuccess());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the bug you fix, you should test the input of, say, 3 email addresses, 2 of which are valid and 1 of which is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working first time contributor First-time contributor test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][Alert] Batch email receiving addresses support sending to valid addresses among them
2 participants