-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement-16534][Master] Switch task support includes method #16594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaoquanTao
requested review from
caishunfeng,
SbloodyS and
ruanwenjun
as code owners
September 6, 2024 02:00
SbloodyS
reviewed
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run mvn spotless:apply
to format the code.
Gallardot
reviewed
Sep 24, 2024
...er-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtils.java
Outdated
Show resolved
Hide resolved
SbloodyS
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gallardot
approved these changes
Sep 26, 2024
SbloodyS
changed the title
[Improvement-16534][Master] switch task doesn't support includes method
[Improvement-16534][Master] Switch task support includes method
Sep 26, 2024
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This PR add polyfill for js engine to support includes method. fix #16534
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
(or)
Pull Request Notice