Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-16534][Master] Switch task support includes method #16594

Merged
merged 10 commits into from
Sep 27, 2024

Conversation

ChaoquanTao
Copy link
Contributor

@ChaoquanTao ChaoquanTao commented Sep 6, 2024

Purpose of the pull request

This PR add polyfill for js engine to support includes method. fix #16534

Brief change log

  • modify SwtichTaskUtils to support includes method

Verify this pull request

This change added tests and can be verified as follows:

  • Added SwitchTaskUtilsTest#testIncludes to verify the change.

(or)

Pull Request Notice

@SbloodyS SbloodyS added this to the 3.3.0 milestone Sep 6, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Sep 6, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run mvn spotless:apply to format the code.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS changed the title [Improvement-16534][Master] switch task doesn't support includes method [Improvement-16534][Master] Switch task support includes method Sep 26, 2024
Copy link

sonarcloud bot commented Sep 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@SbloodyS SbloodyS merged commit b97f6fc into apache:dev Sep 27, 2024
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][Master] switch task doesn't support includes function
4 participants