Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-16647][UI][Workflow Instance] Remove deprecated workflow execution states #16648

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

sdhzwc
Copy link
Contributor

@sdhzwc sdhzwc commented Sep 23, 2024

Purpose of the pull request

close #16647

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added the UI ui and front end related label Sep 23, 2024
@SbloodyS
Copy link
Member

To to target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, just desc). It would not only connect issue to PR but also close issue automatically when PR is be closed.

@sdhzwc
Copy link
Contributor Author

sdhzwc commented Sep 23, 2024

To to target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, just desc). It would not only connect issue to PR but also close issue automatically when PR is be closed.

image
Like this?

@SbloodyS
Copy link
Member

Like this?

Yes.

@SbloodyS SbloodyS changed the title [Improvement-16647][UI][Workflow Instance]remove deprecated workflow execution states [Improvement-16647][UI][Workflow Instance] Remove deprecated workflow execution states Sep 23, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Sep 23, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Sep 23, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Sep 29, 2024

@Gallardot Gallardot merged commit 9a58eca into apache:dev Oct 4, 2024
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement make more easy to user or prompt friendly UI ui and front end related
Projects
None yet
3 participants