[Feature-16658][RPC] Implement of Netty add ssl #16659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxj3
requested review from
caishunfeng,
SbloodyS and
ruanwenjun
as code owners
wangxj3
changed the title
wangxj3
changed the title
ruanwenjun
requested changes
Sep 27, 2024
Comment on lines
+79
to
+88
| public NettyRemotingServer(final NettyServerConfig serverConfig, final NettySslConfig nettySslConfig) { | ||
| this.nettySslConfig = nettySslConfig; | ||
| if (nettySslConfig.isEnabled()) { | ||
| try { | ||
| sslContext = SslContextBuilder.forServer(new File(nettySslConfig.getCertFilePath()), | ||
| new File(nettySslConfig.getKeyFilePath())).build(); | ||
| } catch (SSLException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } |
There was a problem hiding this comment.
NettySslConfig should as a field in NettyServerConfig and NettyClientConfig.
Comment on lines
+151
to
+155
| rpc: | ||
| ssl: | ||
| enabled: false | ||
| cert-file-path: /path/cert.crt | ||
| key-file-path: /path/private.pem |
|
Duplicated with #16673 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md