Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc-16732][Development] development-environment-setup improvement #16733

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

SbloodyS
Copy link
Member

Purpose of the pull request

close #16732

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Oct 24, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Oct 24, 2024
@SbloodyS SbloodyS self-assigned this Oct 24, 2024
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to add the reason why developer need to add this options.

@SbloodyS
Copy link
Member Author

SbloodyS commented Oct 24, 2024

It's better to add the reason why developer need to add this options.

This is the guidance document for starting the development environment. I don't quite understand why we should add reasons since this is not a code interpretation document...

@caishunfeng
Copy link
Contributor

It's better to add the reason why developer need to add this options.

This is the guidance document for starting the development environment. I don't quite understand why we should add reasons since this is not a code interpretation document...

fine, just nip.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun merged commit cf9d487 into apache:dev Oct 25, 2024
36 checks passed
@SbloodyS SbloodyS deleted the improvement_16732 branch October 25, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc][Development] development-environment-setup improvement
3 participants