[Improvement-16887][Dependent Task] Dependet task improvement #16910
Conversation
SbloodyS
added
UI
SbloodyS
requested review from
EricGao888,
songjianet,
caishunfeng,
Gallardot and
ruanwenjun
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import lombok.Data; | ||
| import lombok.EqualsAndHashCode; | ||
|
|
||
| @EqualsAndHashCode(callSuper = true) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
...ache/dolphinscheduler/server/master/engine/executor/plugin/dependent/DependentLogicTask.java
Dismissed
Show dismissed
Hide dismissed
| import lombok.Data; | ||
| import lombok.EqualsAndHashCode; | ||
|
|
||
| @EqualsAndHashCode(callSuper = true) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
|
| } else { | ||
| TaskDefinition taskDefinition = taskDefinitionMap.get(dependentItem.getDepTaskCode()); | ||
| taskDependentResult.setTaskDefinitionCode(taskDefinition.getCode()); | ||
| taskDependentResultDao.upsertTaskDependentResult(taskDependentResult); |
There was a problem hiding this comment.
It would be better if we can set the dependent result into taskInstance's app_link, then we can avoid importing a table here and we can also avoid query the dependent result in other place. cc @caishunfeng
There was a problem hiding this comment.
TaskInstance's app_link is used to store yarn application ids. So I think it's not a good idea.
There was a problem hiding this comment.
It's better to add a field runtime_context to store all runtime context if need.
There was a problem hiding this comment.
I'll create a new table t_ds_task_instance_context to store context.
Purpose of the pull request
close #16887
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md