Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16914] [Task] ParameterUtils will throw exception when the input contains '$[xx]' #16916

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

close #16914

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

@SbloodyS SbloodyS added the bug Something isn't working label Dec 24, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Dec 24, 2024
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit dddf2dc into apache:dev Dec 24, 2024
70 of 72 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixParameter branch December 24, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Task] ParameterUtils will throw exception when the input contains '$[xx]'
3 participants