Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix-16540][Task Plugin] Updated the TaskExecutionContext to pass OUT parameters to the next node #16933

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

[Fix-16540][Task Plugin] Updated the TaskExecutionContext to pass OUT parameters to the next node #16933

wants to merge 1 commit into from

Conversation

Mighten
Copy link
Contributor

@Mighten Mighten commented Dec 30, 2024 •
edited
Loading

Purpose of the pull request

This Pull Request fixes a bug that prevents passing the varPool to the next Shell node, and aims to close #16540.

Brief change log

  • Updated the TaskExecutionContext with the varPool in JSON format after executing the Shell node.

Verify this pull request

This change can be verified as follows:

  1. Set up a shell-node-to-shell-node workflow as follows:
    workflow-definition

  2. Bring workflow online and start it:

  3. Check for Worker log in IntelliJ IDEA Console:

after-fixed-result-console

  • After this PR, the a and b in the varPool can be substituted correctly.

Before this PR, the a and b in the varPool cannot be found:
before-1-not-updated

  1. Check for Workflow Instance DB items with SQL:

workflow-instance-db

  • Record with ID 58: Before this PR, the varPool was NOT properly updated.
  • Record with ID 57: After this PR, the varPool is properly updated.

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Mighten Mighten changed the title Update TaskExecutionContext with newly updated VarPool [Fix-16540]Update TaskExecutionContext with newly updated VarPool Dec 30, 2024
@Mighten Mighten changed the title [Fix-16540]Update TaskExecutionContext with newly updated VarPool [Fix-16540][task-api] Updated the TaskExecutionContext to pass OUT parameters to the next node Dec 30, 2024
@Mighten Mighten changed the title [Fix-16540][task-api] Updated the TaskExecutionContext to pass OUT parameters to the next node [Fix-16540][Task Plugin] Updated the TaskExecutionContext to pass OUT parameters to the next node Dec 30, 2024
@SbloodyS SbloodyS added the bug Something isn't working label Dec 31, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Dec 31, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Mighten Mighten force-pushed the fix-16540 branch 3 times, most recently from ebbea7b to 96fa389 Compare January 2, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng will be requested when the pull request is marked ready for review caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS will be requested when the pull request is marked ready for review SbloodyS is a code owner

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun will be requested when the pull request is marked ready for review ruanwenjun is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@Mighten Mighten

Labels
backend bug Something isn't working
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

[Bug] [task-api] The parameter of type OUT does not have a value on the next node
2 participants
@Mighten @SbloodyS