[Feature-16992][dolphinscheduler-task-seatunnel] Implement added seatunnel configuration generation in the form mode #16993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unnel configuration generation in the form mode
JeremyXin
requested review from
songjianet,
SbloodyS,
caishunfeng and
Gallardot
as code owners
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
|
Hi @JeremyXin , thanks for your contribution. Can you copy and paste the contents of the pdf into the description with english, which will make it easier for others to participate in the discussion and review? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| String seatunnelConfig = envConfig + "\n" + sourceConfig + "\n" + transformConfig + "\n" + sinkConfig; | ||
|
|
||
| log.info("Generate Seatunnel Config => \n{}", seatunnelConfig); |
Check failure
Code scanning / CodeQL
Insertion of sensitive information into log files High
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Implement added seatunnel configuration generation in the form mode.
Try to implement issues #16992.
Full ideas and front and backend effection picture can be found in the pdf file below.
DolphinScheduler Seatunnel插件快速配置方案.pdf
If you have any questions, please contact me in time. Thank you for your review!
close #16992
Brief change log
Modify the front and backend code of the dolphinscheduler-task-seatunnel plugin
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
SeatunnelTaskTest.testSeatunnelConfigGeneration() method.
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md