Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
DongLiang-0 committed Dec 15, 2023
1 parent d1108c6 commit 74f4e5f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 12 deletions.
10 changes: 5 additions & 5 deletions tools/maven/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,11 @@ This file is based on the checkstyle file of Apache Beam.
<property name="severity" value="error"/>
</module>

<module name="IllegalImport">
<property name="illegalPkgs"
value="org.mockito, org.powermock"/>
<message key="import.illegal" value="{0}; Mocking is discouraged. Please refer to the coding guidelines: https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#avoid-mockito---use-reusable-test-implementations."/>
</module>
<!-- <module name="IllegalImport">-->
<!-- <property name="illegalPkgs"-->
<!-- value="org.mockito, org.powermock"/>-->
<!-- <message key="import.illegal" value="{0}; Mocking is discouraged. Please refer to the coding guidelines: https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#avoid-mockito-&#45;&#45;use-reusable-test-implementations."/>-->
<!-- </module>-->
<module name="IllegalImport">
<property name="illegalPkgs"
value="autovalue.shaded, avro.shaded, com.google.api.client.repackaged, com.google.appengine.repackaged"/>
Expand Down
7 changes: 0 additions & 7 deletions tools/maven/suppressions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,4 @@ under the License.
<!-- Java doc -->
<suppress files="org[\\/]apache[\\/]doris[\\/]flink[/].*" checks="JavadocType" />

<!-- For test case -->
<suppress files="org[\\/]apache[\\/]doris[\\/]flink[\\/]sink[\\/]writer[\\/]TestDorisWriter\.java" checks="IllegalImport" />
<suppress files="org[\\/]apache[\\/]doris[\\/]flink[\\/]sink[\\/]writer[\\/]TestDorisStreamLoad\.java" checks="IllegalImport" />
<suppress files="org[\\/]apache[\\/]doris[\\/]flink[\\/]sink[\\/]committer[\\/]TestDorisCommitter\.java" checks="IllegalImport" />
<suppress files="org[\\/]apache[\\/]doris[\\/]flink[\\/]sink[\\/]schema[\\/]SchemaManagerTest\.java" checks="IllegalImport" />
<suppress files="org[\\/]apache[\\/]doris[\\/]flink[\\/]sink[\\/]HttpTestUtil\.java" checks="IllegalImport" />

</suppressions>

0 comments on commit 74f4e5f

Please sign in to comment.