[step1][Improve]Use flink’s checkstyle to format the source connector #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @DongLiang-0 , this is a good job |
DongLiang-0
force-pushed
the
code-format-source_v2
branch
from
ae6c101
to
b5806cd
Compare
JNSimba
reviewed
Dec 14, 2023
flink-doris-connector/src/main/java/org/apache/doris/flink/rest/models/BackendRow.java
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
flink-doris-connector/src/main/java/org/apache/doris/flink/rest/models/QueryPlan.java
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java
Outdated
Show resolved
Hide resolved
JNSimba
reviewed
Dec 14, 2023
flink-doris-connector/src/test/java/org/apache/doris/flink/utils/DateToStringConverter.java
Outdated
Show resolved
Hide resolved
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
The original doris-flink-connector code has not been formatted.
Taking advantage of the opportunity of Contribute Flink Doris Connector to the Flink community, this project formatted using flink’s checkstyle file to try to meet the code style requirements of the flink community.
Apache Flink Code Style and Quality Guide
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...