Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a mismatch between the type of jdbc query result and the datatype #509

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Zhumengze
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem Summary:

The value type obtained by rs.getObject(index + 1) is inconsistent with the field type obtained by flink Context, resulting in a conversion failure in encapsulating flink RowData. For example, the java type corresponding to TINYINT is Java.lang. Byte, while the java type obtained by rs.getObject(index + 1) is Java.lang. Integer, which has a type conversion problem. SMALLINT had the same problem.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
    NO
  2. Has unit tests been added: (Yes/No/No Need)
    NO
  3. Has document been added or modified: (Yes/No/No Need)
    NO
  4. Does it need to update dependencies: (Yes/No)
    NO
  5. Are there any changes that cannot be rolled back: (Yes/No)
    NO

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@JNSimba
Copy link
Member

JNSimba commented Nov 14, 2024

Thank you for your contribution. Could you add some test cases for this PR?

@Zhumengze
Copy link
Contributor Author

@JNSimba No problem,I will submit a new pr later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants