Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support Spark 3.3.0
Removed log4j 1.x, and uses Spark's Logging trait, which uses log4j 2.x in Sprak 3.3.0. For older Spark versions , this change does not break the compability. Code changes are in
ScalaValueReader.scala
Close BufferedReader in DorisStreamLoad
When reading Doris BE rest api's response, BufferedReader should be closed in
DorisStreamLoad
, function:loadBatch
Change spark.minor.version to spark.major.version
In pom.xml, the property
spark.minor.version
is actually spark major version.source jar to include scala code
changes in pom.xml scala-maven-plugin
Issue Number: close #xxx
Problem Summary:
This pr upgrades the code to support Spark 3.3.0, as well as other minor changes.
Checklist(Required)
Does it affect the original behavior: (Yes/No/I Don't know)
No
Has unit tests been added: (Yes/No/No Need)
No unit test is added, but tested manually. in spark-sql CLI.
Has document been added or modified: (Yes/No/No Need)
Does it need to update dependencies: (Yes/No)
Are there any changes that cannot be rolled back: (Yes/No)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...
Test results:
Versions:
truncate Doris table from CLI
Create spark view and insert data into Doris table
Start
spark-sql
CLI in local mode and execute:Check data in Doris
Select data in spark-sql
select * from spark_doris;
How to build spark-doris-connector for Spark 3.3.0
Run the command:
sh build.sh --spark 3.3.0 --scala 2.12