Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](schema-change) Forbid modifying mv related columns #47271

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[fix](schema-change) Forbid modifying mv related columns #47271

wants to merge 11 commits into from

Conversation

TangSiyang2001
Copy link
Collaborator

What problem does this PR solve?

Problem Summary:

Since lack of ability of materialized views to modify columns with schema change(with expressions), forbid modifying such columns.

This behavior has been established since nereids support alter table command #44058.

This PR is for lagecy alter table statement and works for version without nereids' alter table command.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes. Modifying columns related with materialized views will no longer be supported.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@TangSiyang2001
Copy link
Collaborator Author

run buildall

gavinchou
gavinchou previously approved these changes Jan 21, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 32114 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 28661078da819493ddbf16568140e3a8fb9f93c0, data reload: false

------ Round 1 ----------------------------------
q1	17617	5513	5393	5393
q2	2059	306	173	173
q3	10412	1258	723	723
q4	10213	957	510	510
q5	7527	2446	2171	2171
q6	196	165	131	131
q7	919	758	612	612
q8	9251	1376	1145	1145
q9	5286	4987	4917	4917
q10	6823	2354	1869	1869
q11	466	288	250	250
q12	343	366	214	214
q13	17772	3671	3097	3097
q14	220	225	203	203
q15	519	467	451	451
q16	623	615	578	578
q17	580	867	326	326
q18	6981	6422	6312	6312
q19	1229	969	524	524
q20	304	321	198	198
q21	2879	2173	2016	2016
q22	374	324	301	301
Total cold run time: 102593 ms
Total hot run time: 32114 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5507	5469	5521	5469
q2	246	332	248	248
q3	2240	2657	2348	2348
q4	1398	1824	1377	1377
q5	4288	4737	4614	4614
q6	185	158	120	120
q7	1992	2002	1817	1817
q8	2699	2830	2656	2656
q9	7271	7209	7335	7209
q10	3013	3288	2806	2806
q11	590	514	503	503
q12	677	794	620	620
q13	3448	3875	3282	3282
q14	274	291	271	271
q15	510	487	460	460
q16	673	694	646	646
q17	1205	1729	1257	1257
q18	7667	7559	7306	7306
q19	796	1146	1045	1045
q20	2026	2032	1931	1931
q21	5770	5221	5019	5019
q22	606	582	614	582
Total cold run time: 53081 ms
Total hot run time: 51586 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186686 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 28661078da819493ddbf16568140e3a8fb9f93c0, data reload: false

query1	986	375	365	365
query2	6552	2127	2121	2121
query3	6798	215	209	209
query4	33254	23263	22898	22898
query5	4385	619	461	461
query6	284	183	174	174
query7	4608	479	298	298
query8	292	235	223	223
query9	9545	2581	2578	2578
query10	453	307	258	258
query11	18287	15339	14873	14873
query12	156	109	104	104
query13	1676	533	392	392
query14	9596	6661	6348	6348
query15	215	205	194	194
query16	7799	631	464	464
query17	1588	725	559	559
query18	2059	395	310	310
query19	227	185	159	159
query20	120	115	109	109
query21	216	127	103	103
query22	4254	4350	4259	4259
query23	34072	33037	34634	33037
query24	7948	2175	2209	2175
query25	453	437	381	381
query26	1055	249	152	152
query27	2575	463	340	340
query28	5601	2446	2416	2416
query29	526	540	418	418
query30	234	180	157	157
query31	959	868	800	800
query32	69	67	60	60
query33	553	354	300	300
query34	738	848	499	499
query35	797	808	733	733
query36	1008	988	933	933
query37	124	106	78	78
query38	4152	4197	4058	4058
query39	1439	1387	1420	1387
query40	207	116	99	99
query41	52	49	54	49
query42	123	109	102	102
query43	518	534	501	501
query44	1368	792	799	792
query45	179	175	192	175
query46	846	1031	636	636
query47	1831	1851	1800	1800
query48	382	409	313	313
query49	773	480	396	396
query50	611	668	378	378
query51	7008	7016	6844	6844
query52	100	101	92	92
query53	222	246	186	186
query54	480	484	424	424
query55	83	80	85	80
query56	270	254	263	254
query57	1178	1140	1094	1094
query58	241	223	236	223
query59	3232	3277	2934	2934
query60	278	266	253	253
query61	115	152	114	114
query62	795	695	648	648
query63	220	202	190	190
query64	4076	1011	635	635
query65	3215	3167	3143	3143
query66	847	419	309	309
query67	15987	15586	15455	15455
query68	5230	819	536	536
query69	462	294	257	257
query70	1214	1114	1097	1097
query71	390	287	255	255
query72	6148	3857	3845	3845
query73	639	739	359	359
query74	10325	8912	9002	8912
query75	3165	3174	2624	2624
query76	3282	1160	780	780
query77	525	345	288	288
query78	10109	10171	9312	9312
query79	2220	818	595	595
query80	645	598	445	445
query81	536	286	244	244
query82	214	150	126	126
query83	176	204	150	150
query84	238	89	72	72
query85	744	346	299	299
query86	399	318	305	305
query87	4423	4465	4357	4357
query88	4225	2161	2135	2135
query89	390	322	286	286
query90	1894	194	187	187
query91	140	177	107	107
query92	66	56	54	54
query93	1764	850	533	533
query94	642	407	294	294
query95	325	262	258	258
query96	497	598	286	286
query97	2782	2866	2746	2746
query98	225	198	204	198
query99	1287	1351	1242	1242
Total cold run time: 286211 ms
Total hot run time: 186686 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.36 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 28661078da819493ddbf16568140e3a8fb9f93c0, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.04
query3	0.24	0.07	0.07
query4	1.61	0.10	0.11
query5	0.42	0.43	0.42
query6	1.14	0.66	0.65
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.50	0.50
query10	0.54	0.57	0.55
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.61	0.59
query14	2.71	2.83	2.85
query15	0.90	0.82	0.82
query16	0.38	0.38	0.40
query17	1.00	1.07	1.02
query18	0.23	0.22	0.21
query19	1.94	1.74	1.96
query20	0.02	0.01	0.01
query21	15.36	0.93	0.56
query22	0.76	0.88	0.66
query23	15.24	1.46	0.58
query24	4.17	0.50	0.59
query25	0.16	0.27	0.11
query26	0.45	0.14	0.13
query27	0.04	0.05	0.05
query28	12.14	1.05	0.45
query29	12.65	3.98	3.27
query30	0.25	0.09	0.06
query31	2.85	0.60	0.39
query32	3.23	0.59	0.46
query33	2.98	3.05	3.04
query34	16.53	5.20	4.57
query35	4.54	4.56	4.55
query36	0.65	0.49	0.47
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.18	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.32 s
Total hot run time: 30.36 s

dataroaring
dataroaring previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TangSiyang2001 TangSiyang2001 dismissed stale reviews from dataroaring and gavinchou via f2aac10 January 22, 2025 09:19
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 22, 2025
@TangSiyang2001
Copy link
Collaborator Author

run p0

@TangSiyang2001
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32257 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 73af84f77a71bdbbd9eaab3fe38797340d411646, data reload: false

------ Round 1 ----------------------------------
q1	17631	5492	5413	5413
q2	2045	298	190	190
q3	10402	1251	705	705
q4	10204	958	539	539
q5	7485	2364	2545	2364
q6	194	167	133	133
q7	896	771	609	609
q8	9225	1329	1100	1100
q9	5266	4983	4885	4885
q10	6819	2347	1903	1903
q11	474	252	256	252
q12	354	352	217	217
q13	17763	3639	3066	3066
q14	235	232	208	208
q15	511	470	447	447
q16	619	623	576	576
q17	566	858	323	323
q18	7032	6613	6353	6353
q19	1208	958	522	522
q20	307	320	197	197
q21	2759	2168	1950	1950
q22	359	328	305	305
Total cold run time: 102354 ms
Total hot run time: 32257 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5428	5435	5420	5420
q2	233	321	231	231
q3	2249	2619	2321	2321
q4	1418	1874	1372	1372
q5	4314	4682	4656	4656
q6	164	157	123	123
q7	1987	2013	1823	1823
q8	2658	2809	2679	2679
q9	7225	7300	7141	7141
q10	2971	3273	2749	2749
q11	588	507	506	506
q12	691	804	599	599
q13	3492	3834	3298	3298
q14	287	291	256	256
q15	514	467	463	463
q16	637	677	653	653
q17	1207	1735	1231	1231
q18	7733	7535	7343	7343
q19	796	952	1106	952
q20	2004	2076	1894	1894
q21	5634	5260	5049	5049
q22	597	605	566	566
Total cold run time: 52827 ms
Total hot run time: 51325 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184299 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 73af84f77a71bdbbd9eaab3fe38797340d411646, data reload: false

query1	960	400	385	385
query2	6540	2066	2035	2035
query3	6794	228	215	215
query4	33264	23535	23232	23232
query5	4395	618	464	464
query6	281	196	182	182
query7	4594	484	316	316
query8	293	237	229	229
query9	9448	2570	2550	2550
query10	480	319	255	255
query11	18350	15317	15206	15206
query12	157	105	106	105
query13	1652	521	392	392
query14	9622	6487	6980	6487
query15	222	198	181	181
query16	7975	612	446	446
query17	1583	709	559	559
query18	2120	390	293	293
query19	219	177	168	168
query20	118	108	110	108
query21	207	119	102	102
query22	4330	4179	4333	4179
query23	33740	33130	32990	32990
query24	6415	2269	2190	2190
query25	493	440	384	384
query26	1197	264	156	156
query27	2341	464	342	342
query28	5233	2429	2387	2387
query29	730	546	420	420
query30	227	192	153	153
query31	940	834	777	777
query32	87	63	60	60
query33	503	358	295	295
query34	774	828	494	494
query35	815	827	724	724
query36	1008	1013	916	916
query37	120	103	87	87
query38	4130	4137	4015	4015
query39	1439	1408	1387	1387
query40	204	113	104	104
query41	55	49	49	49
query42	133	106	105	105
query43	510	516	471	471
query44	1279	813	803	803
query45	179	177	165	165
query46	852	1021	661	661
query47	1824	1881	1794	1794
query48	383	401	307	307
query49	783	486	391	391
query50	622	665	388	388
query51	4204	4217	4146	4146
query52	107	105	93	93
query53	233	261	189	189
query54	483	500	411	411
query55	85	76	78	76
query56	270	262	234	234
query57	1166	1157	1050	1050
query58	252	242	249	242
query59	3020	3058	2859	2859
query60	292	265	253	253
query61	115	115	116	115
query62	781	727	664	664
query63	227	189	190	189
query64	4626	989	660	660
query65	3218	3115	3126	3115
query66	1077	426	313	313
query67	15831	15675	15390	15390
query68	2188	833	540	540
query69	458	289	256	256
query70	1247	1125	1156	1125
query71	338	287	253	253
query72	5343	3793	3860	3793
query73	638	740	356	356
query74	10083	8955	8778	8778
query75	3154	3179	2636	2636
query76	2789	1165	758	758
query77	487	434	279	279
query78	10025	10343	9276	9276
query79	981	900	595	595
query80	1381	541	446	446
query81	546	275	239	239
query82	576	159	128	128
query83	265	187	152	152
query84	229	92	76	76
query85	1024	379	337	337
query86	415	325	315	315
query87	4506	4424	4464	4424
query88	3607	2224	2183	2183
query89	393	331	283	283
query90	1653	194	194	194
query91	136	140	107	107
query92	66	54	54	54
query93	955	896	534	534
query94	669	377	305	305
query95	343	278	256	256
query96	496	602	288	288
query97	2773	2901	2766	2766
query98	221	203	194	194
query99	1272	1356	1270	1270
Total cold run time: 275864 ms
Total hot run time: 184299 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.47 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 73af84f77a71bdbbd9eaab3fe38797340d411646, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.04	0.03
query3	0.23	0.06	0.07
query4	1.61	0.11	0.11
query5	0.43	0.43	0.40
query6	1.14	0.66	0.66
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.60	0.51	0.52
query10	0.55	0.56	0.54
query11	0.14	0.11	0.11
query12	0.14	0.11	0.10
query13	0.60	0.60	0.59
query14	2.84	2.73	2.74
query15	0.91	0.83	0.82
query16	0.39	0.39	0.36
query17	1.05	1.01	1.01
query18	0.24	0.21	0.22
query19	1.98	1.76	2.07
query20	0.01	0.01	0.01
query21	15.36	0.91	0.57
query22	0.74	1.01	0.72
query23	15.00	1.38	0.53
query24	2.73	1.18	0.90
query25	0.23	0.16	0.21
query26	0.30	0.14	0.14
query27	0.09	0.05	0.04
query28	13.94	1.01	0.43
query29	12.56	3.90	3.26
query30	0.25	0.08	0.07
query31	2.83	0.60	0.39
query32	3.23	0.55	0.47
query33	2.98	3.08	2.99
query34	16.34	5.25	4.47
query35	4.51	4.47	4.51
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.24 s
Total hot run time: 30.47 s

@TangSiyang2001
Copy link
Collaborator Author

run p0

@TangSiyang2001 TangSiyang2001 force-pushed the forbid-mod-mv-related-column branch from 73af84f to 316d6e4 Compare January 24, 2025 12:10
@TangSiyang2001
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32618 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 316d6e49a527d8a56fb4ea714ecba8fc5a284d71, data reload: false

------ Round 1 ----------------------------------
q1	17657	5750	5437	5437
q2	2050	324	182	182
q3	10545	1317	758	758
q4	10265	988	520	520
q5	8092	2433	2197	2197
q6	194	163	130	130
q7	944	756	609	609
q8	9228	1427	1233	1233
q9	5401	4963	4971	4963
q10	6848	2379	1885	1885
q11	470	274	259	259
q12	347	368	222	222
q13	17777	3850	3095	3095
q14	230	234	218	218
q15	550	485	479	479
q16	623	607	592	592
q17	548	877	335	335
q18	7447	6633	6428	6428
q19	1220	945	542	542
q20	322	336	199	199
q21	3159	2263	2023	2023
q22	373	333	312	312
Total cold run time: 104290 ms
Total hot run time: 32618 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5562	5509	5510	5509
q2	238	338	235	235
q3	2303	2677	2389	2389
q4	1406	1904	1401	1401
q5	4371	4875	4787	4787
q6	177	164	126	126
q7	2144	1976	1914	1914
q8	2645	2809	2704	2704
q9	7261	7230	7271	7230
q10	3059	3337	2792	2792
q11	603	503	504	503
q12	740	824	604	604
q13	3592	4072	3318	3318
q14	282	305	276	276
q15	556	488	482	482
q16	675	689	642	642
q17	1268	1782	1261	1261
q18	7960	7684	7571	7571
q19	774	1038	1090	1038
q20	2039	2109	1942	1942
q21	5879	5347	4972	4972
q22	607	641	561	561
Total cold run time: 54141 ms
Total hot run time: 52257 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184717 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 316d6e49a527d8a56fb4ea714ecba8fc5a284d71, data reload: false

query1	964	381	389	381
query2	6525	2173	2163	2163
query3	6793	225	210	210
query4	33430	23345	23281	23281
query5	4320	623	482	482
query6	302	194	184	184
query7	4610	487	318	318
query8	306	244	238	238
query9	9174	2599	2597	2597
query10	449	313	247	247
query11	18099	15103	14765	14765
query12	155	110	109	109
query13	1649	544	407	407
query14	10387	6493	6543	6493
query15	246	194	192	192
query16	7963	623	448	448
query17	1611	739	582	582
query18	2090	422	306	306
query19	233	187	162	162
query20	115	109	107	107
query21	214	120	109	109
query22	4270	4415	4019	4019
query23	33812	32929	33092	32929
query24	6519	2362	2266	2266
query25	480	462	390	390
query26	1224	269	158	158
query27	2001	466	349	349
query28	5305	2436	2389	2389
query29	674	535	418	418
query30	227	179	160	160
query31	978	866	765	765
query32	77	61	67	61
query33	503	348	329	329
query34	750	839	516	516
query35	825	856	737	737
query36	1008	1052	937	937
query37	125	101	73	73
query38	4233	4295	4077	4077
query39	1444	1388	1392	1388
query40	210	112	109	109
query41	53	52	52	52
query42	124	105	101	101
query43	528	539	492	492
query44	1308	814	811	811
query45	175	173	171	171
query46	854	1033	652	652
query47	1789	1837	1799	1799
query48	379	401	318	318
query49	777	491	417	417
query50	639	678	396	396
query51	4154	4147	4119	4119
query52	106	104	94	94
query53	228	274	195	195
query54	484	484	411	411
query55	85	78	79	78
query56	254	269	250	250
query57	1162	1118	1087	1087
query58	248	230	235	230
query59	3026	3206	3073	3073
query60	278	273	249	249
query61	119	116	111	111
query62	787	695	680	680
query63	231	193	198	193
query64	4217	1031	667	667
query65	3223	3173	3137	3137
query66	1076	422	337	337
query67	16025	15629	15233	15233
query68	4297	843	530	530
query69	469	300	259	259
query70	1233	1174	1139	1139
query71	367	279	256	256
query72	5900	3839	3855	3839
query73	661	764	362	362
query74	9921	9216	8805	8805
query75	3187	3107	2661	2661
query76	3116	1180	766	766
query77	475	446	287	287
query78	9958	9883	9440	9440
query79	3174	816	602	602
query80	1373	530	438	438
query81	572	277	235	235
query82	361	152	120	120
query83	175	169	159	159
query84	249	94	75	75
query85	779	366	302	302
query86	417	302	288	288
query87	4489	4466	4490	4466
query88	5080	2199	2182	2182
query89	391	328	293	293
query90	1851	193	197	193
query91	136	145	148	145
query92	70	61	55	55
query93	2727	882	539	539
query94	733	379	300	300
query95	346	275	260	260
query96	485	611	276	276
query97	2762	2893	2788	2788
query98	226	194	198	194
query99	1285	1348	1259	1259
Total cold run time: 283894 ms
Total hot run time: 184717 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 316d6e49a527d8a56fb4ea714ecba8fc5a284d71, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.60	0.11	0.10
query5	0.42	0.44	0.41
query6	1.15	0.66	0.65
query7	0.03	0.02	0.01
query8	0.04	0.03	0.04
query9	0.58	0.52	0.50
query10	0.56	0.55	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.62	0.60
query14	2.75	2.75	2.72
query15	0.90	0.82	0.82
query16	0.38	0.39	0.39
query17	1.00	1.04	1.04
query18	0.23	0.21	0.21
query19	1.99	1.79	2.00
query20	0.02	0.01	0.01
query21	15.39	0.91	0.59
query22	0.75	0.97	0.76
query23	14.99	1.50	0.56
query24	3.25	2.03	1.45
query25	0.16	0.21	0.06
query26	0.22	0.15	0.14
query27	0.06	0.04	0.04
query28	14.42	0.94	0.43
query29	12.59	4.05	3.31
query30	0.26	0.09	0.06
query31	2.82	0.61	0.39
query32	3.22	0.55	0.46
query33	3.01	3.01	3.06
query34	16.67	5.15	4.50
query35	4.51	4.57	4.54
query36	0.63	0.48	0.50
query37	0.10	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.35 s
Total hot run time: 31.27 s

@TangSiyang2001
Copy link
Collaborator Author

run p0

@TangSiyang2001
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32169 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b358486e85c6ec141fbac54db3126e3d3a63f4db, data reload: false

------ Round 1 ----------------------------------
q1	17605	5442	5365	5365
q2	2044	294	165	165
q3	10428	1192	768	768
q4	10218	957	520	520
q5	7508	2330	2131	2131
q6	187	162	131	131
q7	909	757	602	602
q8	9241	1319	1126	1126
q9	5074	4806	4870	4806
q10	6826	2321	1874	1874
q11	473	276	259	259
q12	340	349	217	217
q13	17993	3732	3136	3136
q14	217	222	212	212
q15	512	462	458	458
q16	657	636	596	596
q17	579	861	327	327
q18	7222	6443	6449	6443
q19	1221	955	553	553
q20	302	328	192	192
q21	2852	2184	1980	1980
q22	358	335	308	308
Total cold run time: 102766 ms
Total hot run time: 32169 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5544	5511	5548	5511
q2	238	332	232	232
q3	2407	2713	2383	2383
q4	1444	1858	1420	1420
q5	4439	4858	4702	4702
q6	164	159	124	124
q7	2058	1968	1816	1816
q8	2678	2840	2673	2673
q9	7359	7201	7266	7201
q10	3099	3407	2851	2851
q11	588	515	512	512
q12	672	777	640	640
q13	3897	4130	3617	3617
q14	294	327	294	294
q15	523	500	477	477
q16	686	696	671	671
q17	1252	1731	1321	1321
q18	7659	7475	7411	7411
q19	850	1139	1098	1098
q20	2006	2023	1905	1905
q21	5784	5231	4919	4919
q22	583	590	575	575
Total cold run time: 54224 ms
Total hot run time: 52353 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190945 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b358486e85c6ec141fbac54db3126e3d3a63f4db, data reload: false

query1	1305	983	969	969
query2	6440	2033	2004	2004
query3	10986	4476	4600	4476
query4	60594	28328	23004	23004
query5	5684	586	440	440
query6	413	186	191	186
query7	5519	515	293	293
query8	312	250	243	243
query9	8128	2713	2671	2671
query10	451	297	254	254
query11	17097	15355	15477	15355
query12	156	111	106	106
query13	1422	563	435	435
query14	10462	7505	7052	7052
query15	200	221	197	197
query16	7246	633	530	530
query17	1100	743	595	595
query18	1970	424	329	329
query19	207	177	158	158
query20	117	122	114	114
query21	202	125	101	101
query22	4325	4617	4653	4617
query23	34028	32964	33255	32964
query24	5457	2353	2255	2255
query25	465	479	402	402
query26	667	284	160	160
query27	1808	486	344	344
query28	4310	2563	2499	2499
query29	541	549	418	418
query30	228	189	163	163
query31	926	866	829	829
query32	68	61	56	56
query33	421	362	295	295
query34	768	862	524	524
query35	807	872	734	734
query36	1007	1116	956	956
query37	120	100	77	77
query38	4200	4285	4238	4238
query39	1494	1449	1427	1427
query40	215	115	97	97
query41	50	46	47	46
query42	117	108	103	103
query43	517	523	490	490
query44	1393	854	845	845
query45	187	180	173	173
query46	870	1053	677	677
query47	1893	1907	1804	1804
query48	412	404	331	331
query49	738	508	404	404
query50	666	673	396	396
query51	4338	4306	4198	4198
query52	110	106	100	100
query53	241	269	193	193
query54	484	524	422	422
query55	83	80	82	80
query56	249	284	234	234
query57	1170	1189	1107	1107
query58	246	244	237	237
query59	3012	3166	3001	3001
query60	281	296	260	260
query61	117	121	122	121
query62	752	730	681	681
query63	238	192	189	189
query64	1480	1020	650	650
query65	3265	3131	3170	3131
query66	739	391	293	293
query67	15927	15597	15363	15363
query68	5065	847	534	534
query69	502	300	261	261
query70	1159	1098	1019	1019
query71	401	282	254	254
query72	6148	3821	3705	3705
query73	794	763	372	372
query74	9954	8772	8880	8772
query75	3192	3148	2675	2675
query76	3794	1179	762	762
query77	506	364	288	288
query78	9970	9893	9289	9289
query79	2727	803	606	606
query80	1600	533	443	443
query81	563	272	239	239
query82	363	153	118	118
query83	276	179	153	153
query84	292	87	76	76
query85	772	341	296	296
query86	459	315	298	298
query87	4393	4427	4326	4326
query88	3744	2180	2156	2156
query89	404	329	301	301
query90	1612	187	189	187
query91	133	138	110	110
query92	68	57	55	55
query93	2842	882	540	540
query94	768	411	289	289
query95	332	261	259	259
query96	499	612	285	285
query97	2806	2952	2725	2725
query98	224	199	195	195
query99	1277	1396	1261	1261
Total cold run time: 309080 ms
Total hot run time: 190945 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.72 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b358486e85c6ec141fbac54db3126e3d3a63f4db, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.06
query4	1.63	0.10	0.10
query5	0.41	0.41	0.41
query6	1.16	0.65	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.51	0.49
query10	0.56	0.56	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.59
query14	2.74	2.75	2.83
query15	0.91	0.83	0.82
query16	0.40	0.39	0.38
query17	1.00	0.97	1.04
query18	0.23	0.21	0.20
query19	1.83	1.89	2.03
query20	0.01	0.01	0.01
query21	15.37	0.95	0.59
query22	0.75	0.75	0.79
query23	15.22	1.42	0.60
query24	3.55	0.92	1.31
query25	0.19	0.18	0.11
query26	0.30	0.14	0.14
query27	0.05	0.04	0.04
query28	13.78	1.00	0.44
query29	12.58	3.99	3.24
query30	0.27	0.09	0.07
query31	2.83	0.59	0.40
query32	3.22	0.55	0.46
query33	3.01	3.04	3.01
query34	16.59	5.15	4.52
query35	4.57	4.45	4.58
query36	0.64	0.49	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.18	0.14	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.19 s
Total hot run time: 30.72 s

@TangSiyang2001
Copy link
Collaborator Author

run buildall

starocean999
starocean999 previously approved these changes Jan 27, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@TangSiyang2001 TangSiyang2001 force-pushed the forbid-mod-mv-related-column branch from b68ab7c to b358486 Compare January 27, 2025 09:30
@TangSiyang2001
Copy link
Collaborator Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 27, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 32335 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b358486e85c6ec141fbac54db3126e3d3a63f4db, data reload: false

------ Round 1 ----------------------------------
q1	17581	5555	5379	5379
q2	2041	316	179	179
q3	10391	1213	753	753
q4	10204	974	550	550
q5	7535	2383	2162	2162
q6	188	162	138	138
q7	920	763	609	609
q8	9241	1362	1212	1212
q9	5105	4821	4911	4821
q10	6837	2338	1860	1860
q11	479	284	257	257
q12	341	354	225	225
q13	17771	3690	3143	3143
q14	234	223	210	210
q15	517	476	473	473
q16	623	621	579	579
q17	577	863	332	332
q18	6838	6558	6404	6404
q19	1353	975	559	559
q20	321	325	194	194
q21	3124	2249	1986	1986
q22	366	341	310	310
Total cold run time: 102587 ms
Total hot run time: 32335 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5563	5499	5556	5499
q2	247	332	236	236
q3	2263	2735	2463	2463
q4	1476	1830	1418	1418
q5	4369	4796	4730	4730
q6	174	164	133	133
q7	2091	1926	1832	1832
q8	2644	2843	2734	2734
q9	7299	7180	7250	7180
q10	3033	3279	2810	2810
q11	583	520	502	502
q12	652	722	561	561
q13	3569	3930	3317	3317
q14	282	303	265	265
q15	531	487	467	467
q16	652	713	656	656
q17	1248	1733	1263	1263
q18	7613	7594	7398	7398
q19	809	1121	1052	1052
q20	1992	2036	1892	1892
q21	5702	5248	4885	4885
q22	608	591	575	575
Total cold run time: 53400 ms
Total hot run time: 51868 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192148 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b358486e85c6ec141fbac54db3126e3d3a63f4db, data reload: false

query1	1336	929	922	922
query2	6145	2003	2066	2003
query3	11003	4258	4388	4258
query4	60846	29214	23873	23873
query5	5569	591	485	485
query6	434	203	189	189
query7	5550	515	319	319
query8	335	241	237	237
query9	8289	2713	2696	2696
query10	460	313	251	251
query11	17429	15139	15531	15139
query12	155	108	107	107
query13	1396	542	406	406
query14	10285	7060	6581	6581
query15	213	199	192	192
query16	6626	624	486	486
query17	1098	711	555	555
query18	1770	387	297	297
query19	198	176	156	156
query20	115	116	108	108
query21	227	147	103	103
query22	4512	4668	4451	4451
query23	34205	33528	33178	33178
query24	5518	2372	2384	2372
query25	475	460	436	436
query26	647	257	162	162
query27	1657	471	351	351
query28	4197	2521	2482	2482
query29	570	557	434	434
query30	219	203	170	170
query31	946	876	858	858
query32	74	62	61	61
query33	452	372	311	311
query34	763	879	524	524
query35	828	861	781	781
query36	1005	1063	977	977
query37	123	103	82	82
query38	4292	4320	4232	4232
query39	1530	1438	1433	1433
query40	202	117	99	99
query41	51	49	54	49
query42	125	104	108	104
query43	538	522	489	489
query44	1408	835	843	835
query45	179	180	168	168
query46	871	1081	664	664
query47	1890	1874	1823	1823
query48	394	444	321	321
query49	716	492	406	406
query50	662	678	393	393
query51	4348	4344	4239	4239
query52	111	107	90	90
query53	233	270	194	194
query54	506	525	429	429
query55	84	86	79	79
query56	267	282	264	264
query57	1157	1208	1117	1117
query58	241	239	230	230
query59	3209	3122	3209	3122
query60	278	279	256	256
query61	119	124	133	124
query62	692	743	631	631
query63	228	197	189	189
query64	1262	1027	700	700
query65	3325	3162	3174	3162
query66	726	402	285	285
query67	15812	15482	15701	15482
query68	3366	878	540	540
query69	490	355	252	252
query70	1240	1133	1098	1098
query71	384	285	252	252
query72	6336	3915	3887	3887
query73	655	760	372	372
query74	9936	9042	9025	9025
query75	3196	3140	2691	2691
query76	2896	1183	800	800
query77	542	373	284	284
query78	10089	9873	9344	9344
query79	3052	811	604	604
query80	701	523	457	457
query81	498	271	235	235
query82	420	157	120	120
query83	163	169	154	154
query84	294	93	73	73
query85	763	407	298	298
query86	380	324	307	307
query87	4424	4595	4327	4327
query88	4795	2188	2214	2188
query89	395	325	296	296
query90	1705	188	192	188
query91	145	138	110	110
query92	68	56	49	49
query93	2757	852	533	533
query94	698	413	307	307
query95	334	272	256	256
query96	492	623	282	282
query97	2863	2838	2764	2764
query98	234	197	193	193
query99	1294	1393	1260	1260
Total cold run time: 306731 ms
Total hot run time: 192148 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.12 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b358486e85c6ec141fbac54db3126e3d3a63f4db, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.64	0.10	0.11
query5	0.43	0.43	0.40
query6	1.19	0.65	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.58	0.50	0.50
query10	0.56	0.56	0.54
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.60	0.60
query14	2.84	2.70	2.72
query15	0.91	0.83	0.84
query16	0.38	0.39	0.37
query17	1.01	1.02	1.04
query18	0.22	0.20	0.19
query19	1.86	1.75	1.98
query20	0.02	0.01	0.01
query21	15.37	0.92	0.58
query22	0.77	0.91	0.87
query23	14.99	1.40	0.53
query24	2.61	1.38	0.44
query25	0.20	0.15	0.20
query26	0.34	0.13	0.13
query27	0.04	0.04	0.05
query28	13.56	1.03	0.43
query29	12.64	3.86	3.23
query30	0.25	0.09	0.07
query31	2.83	0.61	0.41
query32	3.23	0.55	0.45
query33	3.01	2.97	3.01
query34	16.65	5.14	4.55
query35	4.57	4.49	4.46
query36	0.65	0.49	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.13 s
Total hot run time: 30.12 s

@TangSiyang2001
Copy link
Collaborator Author

run p0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring

@gavinchou gavinchou Awaiting requested review from gavinchou

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.x kind/behavior-changed reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TangSiyang2001 @Thearas @doris-robot @gavinchou @starocean999 @dataroaring