Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37128][pipeline-connector/mysql] Binlog reader skip shouldEmit filter when snapshot reader skip backfill #3874

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beryllw
Copy link
Contributor

@beryllw beryllw commented Jan 22, 2025

close FLINK-3712.

Motivation

It takes a long time to filter records to ensure exactly-once but when sink supports at-least-once, we can skip it.
When pipeline sink support at-least-once semantics, we can use scan.incremental.snapshot.backfill.skip to skip shouldEmit filter in binlog replay, which will accelerate binlog replay.

for (FinishedSnapshotSplitInfo splitInfo : finishedSplitsInfo.get(tableId)) {
    if (RecordUtils.splitKeyRangeContains(
                    chunkKey, splitInfo.getSplitStart(), splitInfo.getSplitEnd())
            && position.isAfter(splitInfo.getHighWatermark())) {
        return true;
    }
}

…t` filter when snapshot reader skip backfill
@beryllw beryllw marked this pull request as draft January 22, 2025 06:04
@beryllw beryllw marked this pull request as ready for review January 22, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant