Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33137][Connectors/Prometheus] Prometheus connector docs #3

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

nicusX
Copy link
Contributor

@nicusX nicusX commented Aug 8, 2024

English docs page for the connector

@nicusX nicusX marked this pull request as ready for review August 8, 2024 09:37
@nicusX
Copy link
Contributor Author

nicusX commented Oct 25, 2024

New
docs preview with latest changes

@nicusX nicusX changed the title [FLINK-33137] Prometheus connector docs [FLINK-33137][Connectors/Prometheus] Prometheus connector docs Oct 25, 2024
Copy link
Contributor

@hlteoh37 hlteoh37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some nits. Thank you for this @nicusX . It was an incredibly easy read.

docs/content/docs/connectors/datastream/prometheus.md Outdated Show resolved Hide resolved
docs/content/docs/connectors/datastream/prometheus.md Outdated Show resolved Hide resolved
@nicusX
Copy link
Contributor Author

nicusX commented Nov 5, 2024

@hlteoh37 I fixed the typos and improved the readability of the data structure

@hlteoh37
Copy link
Contributor

hlteoh37 commented Nov 5, 2024

@nicusX could we add [FLINK-33137][Connectors/Prometheus][docs] to the commit ID?

@hlteoh37 hlteoh37 merged commit 08dd161 into apache:main Nov 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants