Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-36352][doc] Remove Scala DataStream API related doc #26082

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-36352][doc] Remove Scala DataStream API related doc #26082

wants to merge 1 commit into from

Conversation

X-czh
Copy link
Contributor

@X-czh X-czh commented Jan 26, 2025 •
edited
Loading

What is the purpose of the change

Remove Scala DataStream API related doc.

Verification

Built the doc locally and verified.

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 26, 2025 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

davidradl
davidradl suggested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove the chinese version as well

@davidradl
Copy link
Contributor

Reviewed by Chi on 30/01/2025 Go back to the submitter with review comments.

@X-czh
Copy link
Contributor Author

X-czh commented Jan 31, 2025 •
edited
Loading

we should remove the chinese version as well

Thanks for the reminder, I've updated with the Chinese doc as well.

@X-czh
Copy link
Contributor Author

X-czh commented Feb 7, 2025

@codenohup I've updated the PR, could you help take a look again?

codenohup
codenohup approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@codenohup codenohup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your update.

@X-czh
Copy link
Contributor Author

X-czh commented Feb 8, 2025

@codenohup Thanks for the review, squashed the commits. @reswqa Could you help take a look?

@reswqa
Copy link
Member

reswqa commented Feb 11, 2025

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidradl davidradl davidradl requested changes

@reswqa reswqa reswqa approved these changes

@codenohup codenohup codenohup approved these changes

Assignees
No one assigned
Labels
component=Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@X-czh @flinkbot @davidradl @reswqa @codenohup