-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21912][pyflink] Introduce ResolvedSchema in Python Table API #26121
base: master
Are you sure you want to change the base?
Conversation
I missed some docs updates, will turn this PR back to draft until i've updated them. |
82e6994
to
eccd720
Compare
eccd720
to
ed9bd73
Compare
:class:`pyflink.table.catalog.ComputedColumn`, or :class:`pyflink.table.catalog.MetadataColumn`. | ||
|
||
Every column is fully resolved. The enclosed :class:`~pyflink.table.types.DataType` | ||
indicates whether the column is a time attribute and thus might differ from the original |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I am not sure how to read this sentence, what do we mean by original here? and what might be expected to be different around time attributes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not entirely sure what is meant, the docs for this class were just pulled from the Java equivalent https://nightlies.apache.org/flink/flink-docs-stable/api/java/org/apache/flink/table/catalog/Column.html - perhaps it's not necessary to include this in the Python one, since it doesn't really 'enclose' the data type like the Java one does.
8d46d31
to
a6913cc
Compare
What is the purpose of the change
Currently,
ResolvedSchema
is not supported in the Python Table API. This PR introduces it, as well as addingget_resolved_schema()
toTable
and replacesget_table_schema()
inTableResult
withget_resolved_schema()
, similar to ba5b122.Brief change log
ResolvedSchema
is introduced to Python Table API.Table.get_resolved_schema()
is added.TableResult.get_table_schema()
is replaced byTableResult.get_resolved_schema()
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes (in the sense that it changes the public api ofTableResult
andTable
))Documentation