[GOBBLIN-1866] Preserve sticky bit across distcp copies #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meethngala
suggested changes
Jul 31, 2023
There was a problem hiding this comment.
This change looks good and it will help us preserve sticky bit for directories which was missing earlier. Can we add or update unit tests for testing the preserve logic for sticky bit? You can take a look at this: FileAwareInputStreamDataWriterTest.testAddExecutePermission()
meethngala
reviewed
Aug 2, 2023
| String[] expectPermissions = {"100", "100", "300", "500", "700", "700", "311", "350"}; | ||
| String[] stickyBit = {"" ,"1"}; | ||
| for (String bit : stickyBit) { | ||
| for (int index = 0; index < setPermissions.length; ++index) { |
There was a problem hiding this comment.
I like how you're trying to minimize and reuse the code... :)!
Will-Lo
changed the title
phet
pushed a commit
to phet/gobblin
that referenced
this pull request
Aug 15, 2023
* [gobblin] move sticky bit * [gobblin] add unit test to sticky bit --------- Co-authored-by: Yiming Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Gobblin distcp copies the file permissions but not the sticky bit. As the expectation is that the destination files have preserved permissions from the source, we want to maintain the sticky bit across copies.
Tests
-- Unit test to compare the input and output FsPermission with and without sticky bits with different permission modes
-- A workflow on HDFS where a directory is copied from one location to another.
Commits
☑︎ My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":