[GOBBLIN-1864] Catch exceptions if specific watermark calculation fails #3728
Conversation
| try { | ||
| result.put(type, calculateCompleteness(datasetName, beginInMillis, endInMillis, type, countsByTier) > threshold); | ||
| } catch (IOException e) { | ||
| log.error("Failed to calculate completeness for type " + type, e); |
There was a problem hiding this comment.
Should we set a value to false if its computation fails? So that the returned map always contains two elements.
Just to avoid null when map.get(), ClassicWatermarkUpdater & TotalCountWatermarkUpdater have similar logic like:
protected void computeAndUpdateInternal(Map<KafkaAuditCountVerifier.CompletenessType, Boolean> results,
ZonedDateTime timestampDT) {
if (!results.get(KafkaAuditCountVerifier.CompletenessType.TotalCountCompleteness)) {
return;
}
There was a problem hiding this comment.
Yes good point, I missed that it would cause a null failure there. Instead of always returning false, I changed the checks themselves to handle null properly, that seems safer in case the map is incomplete for some reason.
if (!results.getOrDefault(KafkaAuditCountVerifier.CompletenessType.ClassicCompleteness, false))
Codecov Report
@@ Coverage Diff @@
## master #3728 +/- ##
============================================
+ Coverage 47.45% 50.95% +3.49%
+ Complexity 8687 7215 -1472
============================================
Files 1731 1349 -382
Lines 66736 51126 -15610
Branches 7219 5686 -1533
============================================
- Hits 31671 26051 -5620
+ Misses 32306 22769 -9537
+ Partials 2759 2306 -453 see 383 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ls (apache#3728) * Catch exceptions if specific watermark calculation fails * Add null handling for watermark map
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
If one type of watermark calculation fails (e.g. due to missing tier, or count being 0) it causes all watermarks not to get updated. This PR allows watermarks to get updated individually to avoid blocking other ones if they are working correctly.
Tests
Added unit test which reproduces the issue
Commits