Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1871] Fix bug that hiveMetadataWriter may make the hive schema columns inconsistent with the Avro.schema.literal #3734

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

ZihanLi58
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    hiveMetadataWriter might update Avro.schema.literal without making the corresponding change in hive schema columns
    Also change the HiveOrcSerDeManager to only talk with hdfs when necessary to reduce the num of call to hdfs.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    unit tested

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Merging #3734 (3783ecb) into master (0d3b3b5) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@            Coverage Diff            @@
##             master    #3734   +/-   ##
=========================================
  Coverage     47.08%   47.08%           
  Complexity    10860    10860           
=========================================
  Files          2146     2146           
  Lines         84783    84781    -2     
  Branches       9409     9408    -1     
=========================================
  Hits          39920    39920           
+ Misses        41240    41238    -2     
  Partials       3623     3623           
Files Changed Coverage Δ
...apache/gobblin/hive/writer/HiveMetadataWriter.java 0.00% <0.00%> (ø)
...g/apache/gobblin/hive/orc/HiveOrcSerDeManager.java 60.41% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vikrambohra
Copy link
Contributor

lgtm

@ZihanLi58 ZihanLi58 merged commit af48b31 into apache:master Aug 9, 2023
6 checks passed
phet pushed a commit to phet/gobblin that referenced this pull request Aug 15, 2023
…ma columns inconsistent with the Avro.schema.literal (apache#3734)

* address comments

* use connectionmanager when httpclient is not cloesable

* [GOBBLIN-1871]Fix bug that hiveMetadataWriter may make the hive schema columns inconsistent with the Avro.schema.literal

---------

Co-authored-by: Zihan Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants