Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1890] Offset ranges allow multiple formats GMIP #3753

Merged

Conversation

homatthew
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    It's possible for GMIP to support processing GMCEs that correspond to records from different kafka brokers. This can be done by passing in extra information as a prefix to the offset range map. However, we must also update the algorithm for fetching the topic name to allow for a prefix.

For example, the following offset range keys should be valid and all parse to the topicname

  • topicname-0
  • kafkaBroker1.topicname-0
  • colocation-kafkabroker1.topicname-0

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    image

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Merging #3753 (49261bc) into master (e6368a2) will increase coverage by 1.65%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3753      +/-   ##
============================================
+ Coverage     47.08%   48.73%   +1.65%     
+ Complexity    10874     3552    -7322     
============================================
  Files          2147      694    -1453     
  Lines         84911    28212   -56699     
  Branches       9420     3285    -6135     
============================================
- Hits          39981    13750   -26231     
+ Misses        41296    13068   -28228     
+ Partials       3634     1394    -2240     
Files Changed Coverage Δ
.../gobblin/iceberg/writer/IcebergMetadataWriter.java 70.80% <100.00%> (ø)

... and 1458 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ZihanLi58 ZihanLi58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ZihanLi58 ZihanLi58 merged commit 0ab094a into apache:master Aug 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants