Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1912] Highwtm query record parsing fix #3777

Merged

Conversation

gautamguptabasant
Copy link
Contributor

@gautamguptabasant gautamguptabasant commented Sep 15, 2023

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

The new response looks as follows when there is no valid result of the MAX query:

{
    "totalSize": 1,
    "done": true,
    "records": [
        {
            "attributes": {
                "type": "AggregateResult"
            },
            "expr0": null
        }
    ]
}

When there is a valid value, it looks as follows:

{
    "totalSize": 1,
    "done": true,
    "records": [
        {
            "attributes": {
                "type": "AggregateResult"
            },
            "expr0": "2023-09-15T05:21:41.000+0000"
        }
    ]
}

Tests

  • Added UTs to test parsing of the response in various cases.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

- We updated the Salesforce high watermark query to use MAX aggregate function instead of order by with limit 1.
- The response for the aggregate query is a bit different from the previous version.
- Updating the parsing logic accordingly as part of this PR.
@Will-Lo Will-Lo changed the title Highwtm query record parsing fix [GOBBLIN-1912] Highwtm query record parsing fix Sep 15, 2023
@Will-Lo Will-Lo merged commit c7762fb into apache:master Sep 15, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants