feat: support merge append action #902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
reviewed
Jan 20, 2025
| @@ -1182,6 +1182,12 @@ impl ManifestEntry { | |||
| pub fn data_file(&self) -> &DataFile { | |||
| &self.data_file | |||
| } | |||
|
|
|||
| /// get file sequence number | |||
There was a problem hiding this comment.
Suggested change
| /// get file sequence number | |
| /// File sequence number indicating when the file was added. Inherited when null and status is 1 (added). |
jonathanc-n
reviewed
Feb 14, 2025
There was a problem hiding this comment.
Overall just some small nits. implementing the defaults values for new fields can be done after this pr (#737)
| // Enable merge append for table | ||
| let tx = Transaction::new(&table); | ||
| table = tx | ||
| .set_properties(HashMap::from([ |
There was a problem hiding this comment.
Should we also try adding a test here for the MANIFEST_TARGET_SIZE_BYTES property?
| /// Finished building the action and apply it to the transaction. | ||
| pub async fn apply(self) -> Result<Transaction<'a>> { | ||
| if self.merge_enabled { | ||
| let process = MergeManifsetProcess { |
There was a problem hiding this comment.
Suggested change
| let process = MergeManifsetProcess { | |
| let process = MergeManifestProcess { |
| } | ||
| } | ||
|
|
||
| impl ManifestProcess for MergeManifsetProcess { |
There was a problem hiding this comment.
Suggested change
| impl ManifestProcess for MergeManifsetProcess { | |
| impl ManifestProcess for MergeManifestProcess { |
Comment on lines
+388
to
+393
| struct MergeManifsetProcess { | ||
| target_size_bytes: u32, | ||
| min_count_to_merge: u32, | ||
| } | ||
|
|
||
| impl MergeManifsetProcess { |
There was a problem hiding this comment.
Suggested change
| struct MergeManifsetProcess { | |
| target_size_bytes: u32, | |
| min_count_to_merge: u32, | |
| } | |
| impl MergeManifsetProcess { | |
| struct MergeManifestProcess { | |
| target_size_bytes: u32, | |
| min_count_to_merge: u32, | |
| } | |
| impl MergeManifestProcess { |
Comment on lines
+419
to
+420
| for manifset_file in manifest_bin { | ||
| let manifest_file = manifset_file.load_manifest(&file_io).await?; |
There was a problem hiding this comment.
Suggested change
| for manifset_file in manifest_bin { | |
| let manifest_file = manifset_file.load_manifest(&file_io).await?; | |
| for manifest_file in manifest_bin { | |
| let manifest_file = manifest_file.load_manifest(&file_io).await?; |
| Ok(merged_bins.into_iter().flatten().collect()) | ||
| } | ||
|
|
||
| async fn merge_manifeset<'a>( |
There was a problem hiding this comment.
Suggested change
| async fn merge_manifeset<'a>( | |
| async fn merge_manifest<'a>( |
| @@ -267,13 +376,174 @@ trait SnapshotProduceOperation: Send + Sync { | |||
| struct DefaultManifestProcess; | |||
|
|
|||
| impl ManifestProcess for DefaultManifestProcess { | |||
| fn process_manifeset(&self, manifests: Vec<ManifestFile>) -> Vec<ManifestFile> { | |||
| manifests | |||
| async fn process_manifeset<'a>( | |||
There was a problem hiding this comment.
Suggested change
| async fn process_manifeset<'a>( | |
| async fn process_manifest<'a>( |
| } | ||
| } | ||
|
|
||
| trait ManifestProcess: Send + Sync { | ||
| fn process_manifeset(&self, manifests: Vec<ManifestFile>) -> Vec<ManifestFile>; | ||
| fn process_manifeset<'a>( |
There was a problem hiding this comment.
Suggested change
| fn process_manifeset<'a>( | |
| fn process_manifest<'a>( |
| } | ||
|
|
||
| impl ManifestProcess for MergeManifsetProcess { | ||
| async fn process_manifeset<'a>( |
There was a problem hiding this comment.
Suggested change
| async fn process_manifeset<'a>( | |
| async fn process_manifest<'a>( |
| return Ok(manifests); | ||
| } | ||
|
|
||
| let first_manifest = manifests[0].clone(); |
There was a problem hiding this comment.
Would this be an expensive clone (not wrapped in arc)? is there a way to avoid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complete #736