Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Split schema module to multi file module #989

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Feb 23, 2025

close #981

  • Schema and SchemaBuilder are kept in schema/mod.rs
  • All other individual functions (along with the tests) are moved into a new file.

close apache#981

- `Schema` and `SchemaBuilder` are kept in `schema/mod.rs`
- All other individual functions (along with the tests) are moved into a new file.

Signed-off-by: xxchan <[email protected]>
@xxchan xxchan force-pushed the xxchan/confident-swift branch from 2eb3193 to afd4264 Compare February 23, 2025 12:29
@xxchan
Copy link
Member Author

xxchan commented Feb 23, 2025

cc @liurenjie1024

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xxchan for fixing this, LGTM!

@liurenjie1024 liurenjie1024 merged commit 90f39e8 into apache:main Feb 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split schema module to multi file module.
2 participants