Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-24267 Heap lock manager behave incorrectly in case of overflow #5096

Merged
merged 10 commits into from
Jan 27, 2025
Merged

IGNITE-24267 Heap lock manager behave incorrectly in case of overflow #5096

merged 10 commits into from
Jan 27, 2025

Conversation

vldpyatkov
Copy link
Contributor

@vldpyatkov vldpyatkov commented Jan 22, 2025 •
edited
Loading 

Benchmark                 (batch)  (fsync)  (lockSlots)  (partitionCount)  (useLocks)   Mode  Cnt       Score       Error  Units
UpsertKvBenchmark.upsert        1    false      1048576                32          V1  thrpt   20  147541.810 ± 28774.922  ops/s
UpsertKvBenchmark.upsert        1    false      1048576                32          V2  thrpt   20  162817.990 ± 15843.593  ops/s
UpsertKvBenchmark.upsert        1    false       131072                32          V1  thrpt   20  155244.093 ± 23497.022  ops/s
UpsertKvBenchmark.upsert        1    false       131072                32          V2  thrpt   20  157714.481 ± 17053.298  ops/s
UpsertKvBenchmark.upsert        1    false         1024                32          V1  thrpt   20  144612.223 ± 32303.130  ops/s
UpsertKvBenchmark.upsert        1    false         1024                32          V2  thrpt   20  164248.990 ± 16018.491  ops/s

https://issues.apache.org/jira/browse/IGNITE-24267

ascherbakoff
ascherbakoff suggested changes Jan 24, 2025
View reviewed changes
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItLockTableTest.java Show resolved Hide resolved
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/HeapLockManager.java
/** Raw slots size. */
private final int rawSlotsMaxSize;
/** An unused state to avoid concurrent allocation. */
private LockState removedLockState;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it's not static ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it uses a deadlock prevention policy configuration, which is available only on start.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it.

modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/HeapLockManager.java Outdated Show resolved Hide resolved
@vldpyatkov vldpyatkov merged commit ff36633 into apache:main Jan 27, 2025
1 check passed
@vldpyatkov vldpyatkov deleted the ignite-24267 branch January 27, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascherbakoff ascherbakoff ascherbakoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vldpyatkov @ascherbakoff