IGNITE-24247 Indexes created with table must be created in AVAILABLE state #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtern
force-pushed
the
ignite-24247
branch
3 times, most recently
from
cc914e9 to
440313a
Compare
xtern
changed the title
AMashenkov
reviewed
Jan 24, 2025
| for (UpdateEntry updates : command.get(catalog)) { | ||
| catalog = updates.applyUpdate(catalog, INITIAL_CAUSALITY_TOKEN); | ||
| for (UpdateEntry updates : command.get(updateContext)) { | ||
| updateContext = new UpdateContext(updates.applyUpdate(updateContext.catalog(), INITIAL_CAUSALITY_TOKEN)); |
There was a problem hiding this comment.
Why don't reuse updateContext instance and call UpdateContext.updateCatalog() instead of creating a new objectt.
AMashenkov
reviewed
Jan 24, 2025
Comment on lines
+488
to
+489
| int versionAfter = catalogManager.latestCatalogVersion(); | ||
| assertThat(versionAfter, equalTo(versionBefore + 1)); |
There was a problem hiding this comment.
I guess, here we want to be sure index is not available for SQL in registered/building state.
So, we table and index should be created using separate catalog command commands.
However, your case fix make sense. Let's have both tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-24247
UpdateContextthat holds a set of table ids.CreateTableCommand, we add the table ID to the context.CreateIndexCommand, we set the status of the index depending on whether there was a create table command for the corresponding table in the same batch.UpdateProducerinterface has changed.