Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Support linking system libprotobuf.a when building arrow #6129

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

jackylee-ch
Copy link
Contributor

@jackylee-ch jackylee-ch commented Jun 18, 2024

What changes were proposed in this pull request?

Fix the bug in arrow-15.0.0, which has already been fixed in 16.0.0 or higher version.

See apache/arrow#40015.

How was this patch tested?

GA

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@jackylee-ch jackylee-ch changed the title [VL] Support prebuild protobuf in arrow [VL] Support prebuild libprotobuf.a in arrow Jun 18, 2024
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PHILO-HE PHILO-HE changed the title [VL] Support prebuild libprotobuf.a in arrow [VL] Support linking system libprotobuf.a when building arrow Jun 19, 2024
@PHILO-HE PHILO-HE merged commit 4c7d8be into apache:main Jun 19, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants