Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7112][CH] Pushdown aggregation's pre-projection ahead expand node #7142

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

lgbo-ustc
Copy link
Contributor

@lgbo-ustc lgbo-ustc commented Sep 6, 2024

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Fixes: #7112

The pre-prejction is added in PullOutProjectHelper.scala, we should not change this strategy. So adding a new rule to make this should be OK.

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

unit tests

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

github-actions bot commented Sep 6, 2024

#7112

Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 6, 2024

Run Gluten Clickhouse CI

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgbo-ustc lgbo-ustc merged commit d49efdf into apache:main Sep 10, 2024
7 checks passed
dcoliversun pushed a commit to dcoliversun/gluten that referenced this pull request Sep 11, 2024
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH]Pushdown extra projection before expand
2 participants