#1708 - Replace original implementation and remove copyright info from license file #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fo from license file
11 tasks
|
kogito-apps GHA test failure can be ignored as it's being worked on. |
jomarko
requested changes
Dec 13, 2024
| @@ -234,17 +234,6 @@ for drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/Ja | |||
| (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF | |||
| THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
|
|
|||
| ------------------------------------------------------------------------------------ | |||
| for drools-decisiontables/src/main/java/org/drools/decisiontable/parser/csv/CsvLineParser.java | |||
There was a problem hiding this comment.
Please, update also https://github.com/apache/incubator-kie-drools/blob/main/.rat-excludes, we need to remove the entry CsvLineParsrer from there
Comment on lines
57
to
59
| if (line.isEmpty()) { | ||
| fields.add(""); | ||
| return fields; |
There was a problem hiding this comment.
In past, we used often Collections.singletoneList, what is your opinion about:
if (line.isEmpty()) {
return Collections.singletonList("");
}
Comment on lines
43
to
44
| public CsvLineParser(char delimiter) { | ||
| this.delimiter = delimiter; |
There was a problem hiding this comment.
Do we want to keep this constructor? I was not able to find its usage, to me it seems we use only the default one.
There was a problem hiding this comment.
good point, I wasn't completely sure and that's why cheated and sent this way so to have the CI tell me that if in the codebase we had this used somehow :)
mariofusco
approved these changes
Dec 13, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Dec 17, 2024
…fo from license file (apache#6195) * apache#1708 - Replace original implementation and remove copyright info from license file * incorporating PR review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1708