Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do less aggressive subject nesting #429

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Humbedooh
Copy link
Member

This addresses #427 by only allowing sort-by-subject to
happen if we can establish that an email is a reply.

This addresses #427 by only allowing sort-by-subject to
happen if we can establish that an email is a reply.
@sebbASF
Copy link
Contributor

sebbASF commented Jan 7, 2018

I don't think it makes sense to match by subject even if there is a reply prefix indicator.

If there are two identical subjects, they are likely to both get replies, so they will still get tangled up.

@Humbedooh
Copy link
Member Author

That will only be true if there is no IRT or References header.
It's by no means perfect, but would you prefer the alternative that we could show 100 'threads' that are essentially the same thread?

@sebbASF
Copy link
Contributor

sebbASF commented Jan 7, 2018

There will only be 100 unconnected threads if the mailers are broken and don't provide Reference headers. Are there many such broken clients?

Anyway I think it's better to have broken threads than to merge unrelated threads.
In the latter case it's easy to lose sight of the misfiled mail (indeed that's what alerted me to the problem; I could not see the mail I had just sent).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants