fix: Solve the conflict problem of introducing multiple versions of knadh #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Pls fix the ci failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1bf4369 该 pr 引入了 knadh 两个版本 v1.5.0 和 v2.1.2，seata-go-sample 中引入的是 v1.4.4 版本，导致多个不同的版本引入冲突。通过 go mod graph 查看了项目中库的依赖关系，主要是 dubbo-go 中依赖 knadh，目前最新版本的 dubbo-go 引入的是 v1.5.0，所以将 dubbo-go 的版本升级到了 v3.1.1，knadh 统一成了 v1.5.0。
seata-go-sample pr ： apache/incubator-seata-go-samples#60