Skip to content

Commit

Permalink
Remove FlinkClientTrait duplicate code
Browse files Browse the repository at this point in the history
  • Loading branch information
ChengJie1053 committed Jul 25, 2023
1 parent fda08d0 commit 5e71879
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -487,8 +487,6 @@ trait FlinkClientTrait extends Logger {
commandLine: CommandLine): Configuration = {

require(activeCustomCommandLine != null, "activeCustomCommandLine must not be null.")
val executorConfig = activeCustomCommandLine.toConfiguration(commandLine)
val customConfiguration = new Configuration(executorConfig)
val configuration = new Configuration()
val flinkDefaultConfiguration = getFlinkDefaultConfiguration(flinkHome)
flinkDefaultConfiguration.keySet.foreach(
Expand All @@ -498,7 +496,7 @@ trait FlinkClientTrait extends Logger {
case _ =>
}
})
configuration.addAll(customConfiguration)
configuration.addAll(activeCustomCommandLine.toConfiguration(commandLine))
configuration
}

Expand Down

0 comments on commit 5e71879

Please sign in to comment.