Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Introduce flink jdbc catalog store plugin. #3914

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Conversation

Mrart
Copy link
Contributor

@Mrart Mrart commented Jul 25, 2024

Contribution Checklist

  • Make sure that the pull request corresponds to a 3913.

What changes were proposed in this pull request

Issue Number: close #3913

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

jdbc factory load
*jdbc catalog crud test*

This change added tests and can be verified as follows:

  • *Added Test to verify the change.
  • Manually verified the change by testing locally. -->

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes)

@wolfboys
Copy link
Member

hi Mrart:

HI, thanks for your contribution. There are a few questions to discuss:

  1. Currently, this PR only implements catalog storage. What we need to do is catalog management. Of course, catalog management includes storage. Do you have a complete plan for the catalog management feature? Can it be divided into subtasks like this PR? In this way, we can better assess risks and know the development progress
  2. The current PR only implements MySQL storage and has JSON type. How do we support databases, such as MySQL, PGSQL, and h2 on the streampark platform? Do you have any relevant plans?

@Mrart
Copy link
Contributor Author

Mrart commented Jul 28, 2024

hi Mrart:

HI, thanks for your contribution. There are a few questions to discuss:

  1. Currently, this PR only implements catalog storage. What we need to do is catalog management. Of course, catalog management includes storage. Do you have a complete plan for the catalog management feature? Can it be divided into subtasks like this PR? In this way, we can better assess risks and know the development progress
  2. The current PR only implements MySQL storage and has JSON type. How do we support databases, such as MySQL, PGSQL, and h2 on the streampark platform? Do you have any relevant plans?

1.In the next pr, I'll provide a full catalog backend management implementation. And help coordinate the front-end resources.
2. As mysql I insert json value only use java string,It can supported pg and h2, I have compatibility it by design.

@Mrart Mrart requested review from wolfboys and SbloodyS July 29, 2024 00:24
@Mrart Mrart requested a review from wolfboys July 30, 2024 13:12
@wolfboys
Copy link
Member

hi:
Why delete .idea/icon.png and idea/vcs.xml?

Copy link

sonarcloud bot commented Jul 31, 2024

@Mrart
Copy link
Contributor Author

Mrart commented Jul 31, 2024

hi: Why delete .idea/icon.png and idea/vcs.xml?

When moving the module of the project, the load fails, delete the idea directory again and pour it in. Restores.idea/icon.png and idea/vcs.xml

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit 180bfb2 into apache:dev Jul 31, 2024
44 of 45 checks passed
@Mrart Mrart deleted the 3913 branch September 5, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[catalog] Introduce flink jdbc catalog store plugin.
3 participants