Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the user experience of the Flink web page proxy. #4012

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

lintingbin
Copy link

What changes were proposed in this pull request

Brief change log

  1. Fix the 401 error for the /assets/favicon/manifest.json resource on the Flink page.
  2. Change the Flink page proxy failure from the previous 500 error to a 502 gateway error.
  3. Allow access to the Flink web page not only when the status is running but also when it is not in the EndState.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): no

Copy link

sonarcloud bot commented Aug 31, 2024

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit dc66486 into apache:dev-2.1.5 Aug 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants