Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JCR-5127 Deprecate constants which are defined in expanded form in JCR #221

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

JCR-5127 Deprecate constants which are defined in expanded form in JCR #221

wants to merge 1 commit into from

Conversation

kwin
Copy link
Member

@kwin kwin commented Jan 15, 2025

2.0 API

@kwin kwin requested a review from reschke January 15, 2025 16:17
@kwin kwin force-pushed the feature/deprecate-jcr-constants branch from af9b19f to f24a17f Compare January 15, 2025 16:31
Amoratinos
Amoratinos reviewed Jan 15, 2025
View reviewed changes
Copy link

@Amoratinos Amoratinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot add a comment on line 327 but couldn't be replace the jcr:path constant by the one javax.jcr.Property#JCR_PATH.

jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/JcrConstants.java Show resolved Hide resolved
@kwin
Copy link
Member Author

kwin commented Jan 15, 2025

I cannot add a comment on line 327 but couldn't be replace the jcr:path constant by the one javax.jcr.Property#JCR_PATH.

Yes, but according to its javadoc this is supposed to be used with query results (and this refers to a pseudo property). Not sure if expanded names are supported for all use cases here.

@kwin kwin force-pushed the feature/deprecate-jcr-constants branch from f24a17f to 4bfe375 Compare January 15, 2025 18:34
Amoratinos
Amoratinos approved these changes Jan 16, 2025
View reviewed changes
Copy link

@Amoratinos Amoratinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwin kwin marked this pull request as draft January 16, 2025 07:15
@kwin
Copy link
Member Author

kwin commented Jan 16, 2025

There are some edge cases which require currently qualified form (e.g. comparing Item‘s name against a Set of literals), therefore I am not sure we can really deprecate…

@kwin
JCR-5127 Explicitly link to constants in expanded form in JCR
7fb9097 
2.0 API

Highlight where expanded form names should be used instead
@kwin kwin force-pushed the feature/deprecate-jcr-constants branch from 4bfe375 to 7fb9097 Compare January 25, 2025 16:11
@kwin kwin requested review from Amoratinos and reschke January 25, 2025 16:11
@kwin
Copy link
Member Author

kwin commented Jan 25, 2025

Please have a look again the PR, I no longer deprecated as there are valid use cases which require the qualified form. Instead I just link out to the alternative in the javadoc.

@kwin kwin marked this pull request as ready for review January 27, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amoratinos Amoratinos Awaiting requested review from Amoratinos

@reschke reschke Awaiting requested review from reschke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwin @reschke @Amoratinos