KAFKA-18638 fix flasky testThrottledProducerConsumer.testThrottledProducerConsumer #18689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
JimmyWang6
force-pushed
the
KAFKA-18638
branch
from
f71c97d to
b196359
Compare
m1a2st
reviewed
Jan 30, 2025
| @@ -70,7 +70,7 @@ abstract class BaseQuotaTest extends IntegrationTestHarness { | |||
| this.consumerConfig.setProperty(ConsumerConfig.FETCH_MAX_WAIT_MS_CONFIG, "0") | |||
|
|
|||
| // Low enough quota that a producer sending a small payload in a tight loop should get throttled | |||
| val defaultProducerQuota: Long = 8000 | |||
| val defaultProducerQuota: Long = 6000 | |||
There was a problem hiding this comment.
How can we be confident that 6000 is a stable limit? Would you be able to share the testing results from your local environment that validate this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decrease the value for defaultProducerQuota from 8000 to 6000 to make sure that producing 1000 message will get throttled in testThrottledProducerConsumer.
Committer Checklist (excluded from commit message)
Verify design and implementation
Verify test coverage and CI build status
Verify documentation (including upgrade notes)