-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-10822 Force some stdout from system tests for Travis #9712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the build is still in error?
Thanks for your reviews. The main purpose of this PR is to avoid timeout from downgrade_test.py/upgrade_test.py. I browse the test results and the timeout does not happen on downgrade_test.py/upgrade_test.py again. After fixing the timeout issue, I will go back to dead with the true failure of system tests. |
d71fb3f
to
28600af
Compare
28600af
to
4c07e54
Compare
4c07e54
to
7fa43b4
Compare
The timeout of "no output" is caused by only |
@@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, security_protoc | |||
self.setup_services(kafka_version, compression_types, security_protocol, static_membership) | |||
self.await_startup() | |||
|
|||
self.logger.info("First pass bounce - rolling upgrade") | |||
print("First pass bounce - rolling upgrade", flush=True) # Force some stdout for Travis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems weird. If we want to force stdout, we should configure the logger to do so, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to configure ducktape
to force more output but ducktape
supports only --debug
. It is too noisy to me.
Another way is to make a patch to ducktape
for INFO level support. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: https://issues.apache.org/jira/browse/KAFKA-10822
downgrade_test.py/upgrade_test.py does upgrade/downgrade for each tests. the upgrade/downgrade tasks take 10+ mins in Travis env so we ought to print something in order to avoid timeout caused by Travis.
Committer Checklist (excluded from commit message)