fix(tests): flaky test case in BLMPOP command #2754
Merged
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cause should be the blocking callback was triggered after pushing the key1's elements. And the key1 will be consumed before key2 because BLMPOP command will check keys by order when waking up. We can fix by putting the key1 before key2, so that the key order is always correct even if the blocking callback was delayed.
torwig
approved these changes
Jan 31, 2025
|
PragmaTwice
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause should be the blocking callback was triggered after pushing the key1's elements. The key1 will be consumed before key2 because the BLMPOP command will check keys by order when waking up. We can fix this by putting the key1 before key2 so that the key order is always correct even if the blocking callback was delayed.
This closes #2752.