Skip to content

Commit

Permalink
[KYUUBI #6859] Exclude log4j12 from hive engine module classpath
Browse files Browse the repository at this point in the history
### Why are the changes needed?

Kyuubi uses log4j2 as the logging framework, while I found that the Hive SQL engine module still polls log4j 1.2 to the classpath unexpectedly, we should exclude it to avoid potential issues.

```
build/mvn dependency:tree -pl :kyuubi-hive-sql-engine_2.12
```
```
...
[INFO] +- org.apache.hive:hive-service:jar:3.1.3:provided
[INFO] |  +- org.apache.hive:hive-exec:jar:3.1.3:provided
[INFO] |  |  +- org.apache.zookeeper:zookeeper:jar:3.4.6:provided
[INFO] |  |  |  +- log4j:log4j:jar:1.2.16:provided
...
```

### How was this patch tested?

Checks `build/mvn dependency:tree | grep 'log4j:log4j:jar:1.2'` returns nothing and pass GHA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #6859 from pan3793/exclude-log4j1.

Closes #6859

287cf78 [Cheng Pan] Exclude log4j12 from hive engine module classpath

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit f844afa)
Signed-off-by: Cheng Pan <[email protected]>
  • Loading branch information
pan3793 committed Dec 25, 2024
1 parent e924006 commit 04b1139
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions externals/kyuubi-hive-sql-engine/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-yarn-registry</artifactId>
</exclusion>
<exclusion>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</exclusion>
</exclusions>
</dependency>

Expand Down

0 comments on commit 04b1139

Please sign in to comment.